bug introduced by commit c4276791713e47a76433122ddf7fdedb2a5a3d44 (pytest <=7.4.4)

[mguijarr]

I am really sorry to say, a subtle bug has been introduced by this commit, and I didn't see it while doing the review 😫

At the moment, modules is always [''] which prevents Redis to start...
I wonder how it could pass all tests ?

In anyways, the fix is super easy, in file pytest_redis/config.py instead of:

if (modules := get_conf_option("modules")) is not None:
                                             ^^^^^^^^^^
        modules = modules.split(",")
else:
        modules = []

The config key is empty string so it is enough to make the test as: if (modules := get_conf_option("modules")):

Again, I apologize for not having seen it before.

[mguijarr]

The fix that works for me is #678

[mguijarr]

Hmm... My bad 🤔 In fact there seem to be no problem 😅 Sorry... Something remains in my code that is passing modules or something like this !

[fizyk]

Could be an empty call to modules @mguijarr

[mguijarr]

I identified the problem: the code in commit c427679 does not work with pytest <=7.4.4 ; the behaviour in pytest 8.0 is correct, this corresponds to this change:

pytest-dev/pytest#11282

More specifically the line that was causing problem in 7.4.4 is:

https://github.com/pytest-dev/pytest/blob/b73b4c464c6fa54f55a1c6ed8eaceb5529a161bb/src/_pytest/config/__init__.py#L1527

[mguijarr]

So, to keep compatibility with pytest <8 , I would recommend applying the proposed MR, if you want