Fix. Integration. Ninja forms getting form fields fixed. (#462)

* Fix. Integration. Ninja forms getting form fields fixed.

* Fix. Code. Code style fixed.

* Fix. Code. Psalm notice fixed.

* Fix. Integration. Ninja forms new way form data collecting logic fixed.

* Fix. Code. Psalm notices fixed.

* Fix. Code. Psalm notices fixed #2.

* Fix. Integration. Ninja Forms nickname detection improved.

* Fix. Integration. New way getting fields improved.

* Fix. Code.  Code style and psalm notices fixed.

Author: Glomberg

inc/cleantalk-public-integrations.php

@@ -2168,15 +2168,12 @@ function apbct_form__ninjaForms__testSpam()
 
     $checkjs = apbct_js_test(Sanitize::cleanTextField(Cookie::get('ct_checkjs')), true);
 
-    /**
-     * Filter for POST
-     */
-    $input_array = apply_filters('apbct__filter_post', $_POST);
-
-    // Choosing between POST and GET
-    $params = ct_get_fields_any(
-        Get::get('ninja_forms_ajax_submit') || Get::get('nf_ajax_submit') ? $_GET : $input_array
-    );
+    try {
+        $params = apbct_form__ninjaForms__collect_fields_new();
+    } catch (\Exception $_e) {
+        // It is possible here check the reason if the new way collecting fields is not available.
+        $params = apbct_form__ninjaForms__collect_fields_old();
+    }
 
     $sender_email    = isset($params['email']) ? $params['email'] : '';
     $sender_emails_array = isset($params['emails_array']) ? $params['emails_array'] : '';
@@ -2240,6 +2237,86 @@ function apbct_form__ninjaForms__testSpam()
     }
 }
 
+/**
+ * Old way to collecting NF fields data.
+ *
+ * @return array
+ */
+function apbct_form__ninjaForms__collect_fields_old()
+{
+    /**
+     * Filter for POST
+     */
+    $input_array = apply_filters('apbct__filter_post', $_POST);
+
+    // Choosing between POST and GET
+    return ct_gfa(
+        Get::get('ninja_forms_ajax_submit') || Get::get('nf_ajax_submit') ? $_GET : $input_array
+    );
+}
+
+/**
+ * New way to collecting NF fields data - try to get username and email.
+ *
+ * @return array
+ * @throws Exception
+ * @psalm-suppress UndefinedClass
+ */
+function apbct_form__ninjaForms__collect_fields_new()
+{
+    $form_data = json_decode(TT::toString(Post::get('formData')), true);
+    if ( ! $form_data ) {
+        $form_data = json_decode(stripslashes(TT::toString(Post::get('formData'))), true);
+    }
+    if ( ! isset($form_data['fields']) ) {
+        throw new Exception('No form data is provided');
+    }
+    if ( ! function_exists('Ninja_Forms') ) {
+        throw new Exception('No `Ninja_Forms` class exists');
+    }
+    $nf_form_info = Ninja_Forms()->form();
+    if ( ! ($nf_form_info instanceof NF_Abstracts_ModelFactory) ) {
+        throw new Exception('Getting NF form failed');
+    }
+    $nf_form_fields_info = $nf_form_info->get_fields();
+    if ( ! is_array($nf_form_fields_info) && count($nf_form_fields_info) === 0 ) {
+        throw new Exception('No fields are provided');
+    }
+    $nf_form_fields_info_array = [];
+    foreach ($nf_form_fields_info as $field) {
+        if ( $field instanceof NF_Database_Models_Field) {
+            $nf_form_fields_info_array[$field->get_id()] = [
+                'field_key' => TT::toString($field->get_setting('key')),
+                'field_type' => TT::toString($field->get_setting('type')),
+                'field_label' => TT::toString($field->get_setting('label')),
+            ];
+        }
+    }
+
+    $nf_form_fields = $form_data['fields'];
+    $nickname = '';
+    $email = '';
+    $fields = [];
+    foreach ($nf_form_fields as $field) {
+        if ( isset($nf_form_fields_info_array[$field['id']]) ) {
+            $field_info = $nf_form_fields_info_array[$field['id']];
+            if ( isset($field_info['field_key'], $field_info['field_type']) ) {
+                $field_key = TT::toString($field_info['field_key']);
+                $field_type = TT::toString($field_info['field_type']);
+                $fields['nf-field-' . $field['id'] . '-' . $field_type] = $field['value'];
+                if ( stripos($field_key, 'name') !== false ) {
+                    $nickname = $field['value'];
+                }
+                if ( stripos($field_key, 'email') !== false ) {
+                    $email = $field['value'];
+                }
+            }
+        }
+    }
+
+    return ct_gfa($fields, $email, $nickname);
+}
+
 /**
  * Inserts anti-spam hidden to ninja forms
  *