-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Symbolics extension. #187
Conversation
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 85.70% 85.25% -0.45%
==========================================
Files 222 223 +1
Lines 15110 15154 +44
==========================================
- Hits 12950 12920 -30
- Misses 2160 2234 +74
|
Hello, While precompiling I have the following frequent warnings:
I am not sure if this is due to Symbolics.jl overriding the symbolic registrations or some other issue in the symbolic extension of Clapeyron.jl Thanking you, |
i'm still diagnosing what is wrong with that warning. while it still works, it is a bug |
This PR add a Symbolics.jl extension to Clapeyron. we make a bunch of AD functions Symbolics-compatible. this allows us to pass Symbolic Variables into any (VT) bulk property and obtain a symbolic expression corresponding the evaluation of an specific eos at (V,T,z)::Symbolic conditions. one simple example:
Cp1 results in this expression:
This is, of course, the result of combinatorial explosion, a phenomena that affects calculation of Symbolic derivatives, but it is still the exact expression for the calculation of Cp(V,T) using Peng-Robinson.
Some things are not supported. notably:
For work on Symbolic EoS, i suppose that instead of solving single and multicomponent phase equilibria in the library, the system handling the generated expressions is the one in charge of solving the equilibrium conditions. This PR is a step on addressing #186.