-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Units of property functions #250
Comments
hi!, on the doc error, i'm fixing that right away |
Some comment in the preface would be helpful at least to me but I take your point that the information is there in the documentation 🙂. As a tangent to this, it would be nice if mass could passed as an argument to f.ex. volume when dealing with single fluids like IAPWS95 (which is what I have been using so far). I noticed in the docs that this is an option when dealing with mixtures. It would save some tedious calculations for me, but perhaps it is not a good idea for some reason. |
single fluids are mixtures! (of only one component), you can pass a mass argument in the following way:
In this particular example, i pass |
My mistake. I must have made an error when trying this previously. That's great 🙂 Thanks 👍 |
I will keep this open in the meantime. The typo in mass_density was corrected. There is a docs PR that should fix this, but it isn't merged yet. |
Although if I pass the vector argument for the mass I get a no method matching error for a_res. But in any case your solution was what I was looking for. |
Yeah, |
Ooops, missed your comment about keeping this open. Reopened with this. |
Aside: it should be |
It would be nice if the documentation explicitly stated that properties are per unit mol when dealing with a single fluid (for the functions that are not already explicitly intensive such as density). That might be the assumption for some people but certainly not all 😉.
Also, there seems to be a copy-paste error in the docstring for mass_density. It states that it calculates the molar density, not mass density.
The text was updated successfully, but these errors were encountered: