Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOS-CG 2021 #233

Closed
pw0908 opened this issue Nov 21, 2023 · 7 comments
Closed

EOS-CG 2021 #233

pw0908 opened this issue Nov 21, 2023 · 7 comments
Labels
new EoS New Equation of State

Comments

@pw0908
Copy link
Member

pw0908 commented Nov 21, 2023

Multiparameter equation for CCS applications: https://link.springer.com/article/10.1007/s10765-023-03263-6

@longemen3000 longemen3000 added the new EoS New Equation of State label Nov 21, 2023
@ianhbell
Copy link
Contributor

In that vein, you might want to also add the GERG-2008 model for natural gas. I just added it to teqp: usnistgov/teqp#79

@longemen3000
Copy link
Member

longemen3000 commented Dec 12, 2023

GERG2008 is already in Clapeyron (GERG2008), it uses the same general infraestructure as the multiparameter fluids (with an addon for the difference in R)

@ianhbell
Copy link
Contributor

@longemen3000 Ah cool, didn't realize that.

@longemen3000
Copy link
Member

implemented in 0.5.11

@ianhbell
Copy link
Contributor

Nice! Did you implement test values to be sure all the models are exactly the same?

@longemen3000
Copy link
Member

Not yet, I couldn't find test values of EOS-CG-2021 in the original paper. But on the code part, it just reuses the general MultiFluid code, so the only test necessary is that the data values stored in the database are correct

On the data part, for the pure fluid, the fluids are taken from CoolProp JSONs or ported via REFPROP-interop. On the mixture models, I reused the existing ones where available (from EOS-LNG + some Coolprop mixture models), except the one with typos in the publication, that I have to extract from the paper itself(I have a function that generates mixture jsons from paper tables, so it is not completely manual).

@ianhbell
Copy link
Contributor

One key point is to make sure that you are definitely, 100%, using the pure fluid models that are specified in the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new EoS New Equation of State
Projects
None yet
Development

No branches or pull requests

3 participants