From d9997229d2fbe85a9d0edc8e0aae8faa932c033e Mon Sep 17 00:00:00 2001 From: tuutti Date: Fri, 11 Aug 2023 08:35:02 +0300 Subject: [PATCH] UHF-8198: Comment fixes --- README.md | 4 ++-- src/HelfiProxyServiceProvider.php | 8 +++++--- src/PathProcessor/SitePrefixPathProcessor.php | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 5073242..6c0c25c 100644 --- a/README.md +++ b/README.md @@ -119,9 +119,9 @@ if ($varnish_port = getenv('DRUPAL_VARNISH_PORT')) { $config['varnish_purger.settings.varnish_purge_all']['port'] = $varnish_port; } -// Configuration doesn't know about existing config yet so we can't +// Configuration doesn't know about existing config yet, so we can't // just append new headers to an already existing headers array here. -// If you have configured any extra headers in your purge settings +// If you have configured any extra headers in your purge settings, // you must add them here as well. $config['varnish_purger.settings.default']['headers'] = [ [ diff --git a/src/HelfiProxyServiceProvider.php b/src/HelfiProxyServiceProvider.php index 3e4a2e1..d9a9c1d 100644 --- a/src/HelfiProxyServiceProvider.php +++ b/src/HelfiProxyServiceProvider.php @@ -18,9 +18,11 @@ class HelfiProxyServiceProvider extends ServiceProviderBase { * {@inheritdoc} */ public function alter(ContainerBuilder $container) : void { - // PathProcessorLanguage and SitemapPathProcessor have same - // priority. Alter SitemapPathProcessor's priority so - // SitePrefixPathProcessor can be run in between the two. + // PathProcessorLanguage and SitemapPathProcessor have the same + // priority. Alter SitemapPathProcessor's priority, so + // SitePrefixPathProcessor can be run in between the two. Otherwise, + // the routes provided by 'simple_sitemap' path won't be recognized + // via the proxy path. if ($container->hasDefinition('simple_sitemap.path_processor')) { $definition = $container->getDefinition('simple_sitemap.path_processor'); $tags = $definition->getTags(); diff --git a/src/PathProcessor/SitePrefixPathProcessor.php b/src/PathProcessor/SitePrefixPathProcessor.php index 68d0967..37f084f 100644 --- a/src/PathProcessor/SitePrefixPathProcessor.php +++ b/src/PathProcessor/SitePrefixPathProcessor.php @@ -59,7 +59,7 @@ public function processOutbound( if ($options['language'] instanceof LanguageInterface) { $language = $options['language']->getId(); } - // Use already resolved language to figure out active prefix + // Use an already resolved language to figure out active prefix // since it might be different from content language. $prefix = $this->sitePrefix->getPrefix($language);