Skip to content

Add c8kv iosxe clean examples #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

Add c8kv iosxe clean examples #49

merged 2 commits into from
Jan 19, 2022

Conversation

thaixuann
Copy link
Contributor

No description provided.

@thaixuann thaixuann requested a review from a team as a code owner January 18, 2022 20:08
@thaixuann thaixuann requested review from omehrabi and removed request for ThomasJRyan January 18, 2022 20:08
omehrabi
omehrabi reviewed Jan 18, 2022
View reviewed changes
omehrabi
omehrabi approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@omehrabi omehrabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Thai
there are couple of comments in the clean.yaml that need. to be removed

@thaixuann thaixuann requested review from d-the-iii and removed request for GerriorL January 19, 2022 16:10
d-the-iii
d-the-iii approved these changes Jan 19, 2022
View reviewed changes
Copy link

@d-the-iii d-the-iii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good to me. Just wanted to check though, it's safe to release these addresses and passwords right? They aren't actually for anything important?

@thaixuann thaixuann merged commit 178d355 into master Jan 19, 2022
@thaixuann thaixuann deleted the thaing_c8kv_iosxe branch January 19, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-the-iii d-the-iii d-the-iii approved these changes

@omehrabi omehrabi omehrabi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaixuann @d-the-iii @omehrabi @LukasMcClelland