Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires a Cargo.lock file #18

Open
mimoo opened this issue Sep 24, 2021 · 5 comments
Open

requires a Cargo.lock file #18

mimoo opened this issue Sep 24, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@mimoo
Copy link

mimoo commented Sep 24, 2021

There are errors if you don't have a Cargo.lock file, which is common if your repo is a library.

@mimoo mimoo added the bug Something isn't working label Sep 24, 2021
@gmemstr
Copy link
Contributor

gmemstr commented Sep 27, 2021

Yep, this is on me. It was only recently that I realized the use case for the Cargo.lock file (given my knowledge of Node/npm/yarn, I assumed it was beneficial in all cases to have it committed). @mimoo Do you believe relying only on the Cargo.toml file is enough? Or should we try to support both through a parameter.

@mimoo
Copy link
Author

mimoo commented Sep 27, 2021

Is the Cargo.lock file used for caching? In that case yeah I think relying on Cargo.toml could be a good idea, it's just that the cache is going to become invalidated more often (with each patch version increase, for example) but I don't see any way around that.

@gmemstr
Copy link
Contributor

gmemstr commented Sep 29, 2021

Correct - it's used as a primary part of the cache key. But if it's not committed the cache will never be loaded.

@mimoo
Copy link
Author

mimoo commented Sep 29, 2021

Interesting, I think a better way to handle that in Rust would be to just use the latest cache used to build master

@marboledacci
Copy link
Contributor

I see this issue is old, please update if this is still required and provide more details, or close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants