Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Footer #1658

Closed
ChurchCRMBugReport opened this issue Jan 11, 2017 · 3 comments · Fixed by #1673
Closed

Report Footer #1658

ChurchCRMBugReport opened this issue Jan 11, 2017 · 3 comments · Fixed by #1673
Assignees
@DawoudIO
Labels
enhancement Localization Web Report
Milestone
2.5.0

Comments

@ChurchCRMBugReport
Copy link

Generated reports should not have "Sincerely" hard-coded. This should be a config parameter.

Collected Value Title Data
Page Name /FinancialReports.php
Screen Size x
Window Size x
Page Size x
Platform Information Linux lotus 3.2.61-grsec-modsign #1 SMP Tue Aug 12 09:58:26 UTC 2014 x86_64
PHP Version 5.6.29
ChurchCRM Version 2.4.4
Reporting Browser Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36
@DawoudIO
Copy link
Contributor

why not? we have that everyone...

@saulowulhynek
Copy link

HI @DawoudIO . I agree with this idea. Because there are many others ways to end a letter. It will vary according culture. For example, many churches in Brazil ends a letter with "In Christ's love"

@DawoudIO
Copy link
Contributor

ok I'll add a new config setting for that value.

@DawoudIO DawoudIO added this to the 2.5.0 milestone Jan 14, 2017
@DawoudIO DawoudIO self-assigned this Jan 14, 2017
@DawoudIO DawoudIO mentioned this issue Jan 14, 2017
Merged
This was referenced Mar 25, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawoudIO DawoudIO

Labels
enhancement Localization Web Report
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Sincerely config ChurchCRM/CRM
3 participants
@DawoudIO @ChurchCRMBugReport @saulowulhynek