BUG Creating Person Custom Fields in 2.4.3

[saulowulhynek]

When I add the second custom field I get the folow message:

"Can not execute query.
ALTER TABLE person_custom ADD c1 VARCHAR (30) DEFAULT NULL; "

If I press F5, the field appears correctly created. But, when I try to create third field, I get the message:

Can not execute query.
ALTER TABLE person_custom ADD c1 TINYINT (4) DEFAULT NULL;

And so on
With more tries, types and names are mixed.

[saulowulhynek]

[saulowulhynek]

[saulowulhynek]

I added 3 custom fields. When I try update a person's data i get the folow error from
PersonEditor.php?PersonID=1077

Cannot execute query.
REPLACE INTO person_custom SET c1 = NULL, c1 = NULL, c1 = NULL, per_ID = 1077

[saulowulhynek]

I verified that, when I imported data, the same data was imported in the 3 custom fields. Example: I created 3 custom fields as baptism date, id number and second mobile number. When i imported data, the 3 fields was filled with id number.

[chiebert]

Same issue here, fresh install of 2.4.3. The custom fields manager query isn't incrementing the identity number 'c1' for new custom fields, so basically the ALTER query is trying to create a new field with the same primary ID as the last one.

I'm just starting to look into the problem now (brand new to this code, so it may take me a bit!), but I suspect something's wrong around line 124 and following in PersonCustomFieldsEditor.php, which starts:

if (!$bDuplicateNameError) {
          // Find the highest existing field number in the table to determine the next free one.
          // This is essentially an auto-incrementing system where deleted numbers are not re-used.

[chiebert]

Error is in line 128 of PersonCustomFieldsEditor.php, which calls mysqli_num_fields() to calculate $last:

          $fields = mysqli_query($cnInfoCentral, "SHOW COLUMNS FROM person_custom");
          $last = mysqli_num_fields($fields) - 1;

Where it should be mysqli_num_rows() instead:

          $fields = mysqli_query($cnInfoCentral, "SHOW COLUMNS FROM person_custom");
          $last = mysqli_num_rows($fields) - 1;

I had noticed that this error not appear when adding custom family fields, so compared the code at line 168 of FamilyCustomFieldsEditor.php, and spotted the difference.

[chiebert]

It looks like the equivalent problem with family custom fields was fixed on Nov 18 by @crossan007 with commit 58bf29f, but this problem was missed in commit 2732d5e on the same day.