/api/deposits/1/pdf Error

[DawoudIO]

http://192.168.33.10/api/deposits/1/pdf

renders

{
"code": 404,
"message": "No Payments on this Deposit",
"file": "/var/www/public/orm/model/ChurchCRM/Deposit.php",
"line": 378,
"trace": [
"#0 /var/www/public/api/routes/deposits.php(49): ChurchCRM\\Deposit->getPDF()",
"#1 [internal function]: Closure->{closure}(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Array)",
"#2 /var/www/public/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(41): call_user_func(Object(Closure), Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Array)",
"#3 /var/www/public/vendor/slim/slim/Slim/Route.php(325): Slim\\Handlers\\Strategies\\RequestResponse->__invoke(Object(Closure), Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Array)",
"#4 /var/www/public/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(116): Slim\\Route->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
"#5 /var/www/public/vendor/slim/slim/Slim/Route.php(297): Slim\\Route->callMiddlewareStack(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
"#6 /var/www/public/vendor/slim/slim/Slim/App.php(443): Slim\\Route->run(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
"#7 /var/www/public/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(116): Slim\\App->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
"#8 /var/www/public/vendor/slim/slim/Slim/App.php(337): Slim\\App->callMiddlewareStack(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
"#9 /var/www/public/vendor/slim/slim/Slim/App.php(298): Slim\\App->process(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
"#10 /var/www/public/api/index.php(44): Slim\\App->run()",
"#11 {main}"
]
}

[crossan007]

This is intentional - it doesn't make sense to generate a deposit slip with no payments.

[crossan007]

This also should be handled by the client side API Error handler

[DawoudIO]

so this bug is client side ? do you think you can fix it before Sunday (Release Day)

[crossan007]

This is fixed with #1109