Remove sidebar icon size setting & allow iCloud

[IanHollow]

Type of Change

• Refactoring
• UI/UX improvement

Description

The sidebar icon size also changes the icon size in the system settings. I do not mind the size change in finder however the font size becomes a lot smaller in the system settings side bar and that makes it a lot harder to read.

I feel that removing iCloud by default is a little harsh and should be moved a separate script. Apple is all about ecosystem so while some people might not use iCloud disabling this ecosystem feature by default is a very opinionated move.

Testing

I have tested these changes on my system.

Impact

This adds the iCloud back to the sidebar by default and doesn't change the system prefrences sidebar to small icons.

However, if someone has already run this script then the icon size will not change back without resetting it. The same goes for the iCloud sidebar.

You can run a command like this to reset the setting. A restart might be needed as well:
defaults delete NSGlobalDomain NSTableViewDefaultSizeMode

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no errors/warnings/merge conflicts.