-
Notifications
You must be signed in to change notification settings - Fork 0
Add continuous transfer mode #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
77988c7
to
8d1505c
Compare
085add4
to
589871c
Compare
Ooh, nice! I didn’t review in depth yet, but one thing that comes to mind, our goal for this is to sync a directory, where the sending side may still be producing new files, right? So we sync once, but by the time it’s complete, there may be new files, so we do it again, etc., until the difference is very small, then we stop the process that’s writing files, we do a final sync, and at that point we know the copy is complete. With the current implementation, would we need to execute |
Closes: #16
In my use-case it's 2 times.
The transfer is usually much faster than the speed of producing files, so I have not observed this being very useful for the workloads I have worked with so far. There is are some potential risks:
Yes, considering we would not keep the Edit: this is now done and tested. |
84969ff
to
67b7bbe
Compare
d9a1c4e
to
737e2db
Compare
@@ -0,0 +1,289 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about this script, it felt nice to have it during development to validate the integration, but I think it's too time sensitive and unreliable to put into CI.
But if it's not in CI it will get broken over time probably.
Closes: #16