Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fcbk open-graph and twitter-card metas for accounts, video-channels, playlists urls #2996

Merged

Conversation

kimsible
Copy link
Contributor

Fixes: #2989

Tests :

$ npm run build:server
$ NODE_ENV=test npm start

# Playlist 
$ curl http://localhost:9000/videos/watch/playlist/:uuid

# Account
$ curl http://localhost:9000/accounts/:username

# Channel
$ curl http://localhost:9000/video-channels/:name

og-fcbk-playlist
og-fcbk-channel
og-fcbk-account

@kimsible kimsible force-pushed the feat/share-account-and-channel branch from c4dea59 to 9a6e49d Compare July 23, 2020 12:47
Copy link
Owner

@Chocobozzz Chocobozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for accounts, channels and playlists meta tags? https://github.com/Chocobozzz/PeerTube/blob/develop/server/tests/client.ts

Maybe you could also refactor addAccountOrChannelOpenGraphAndMetaTags, addVideoPlaylistOpenGraphAndMetaTags and addVideoOpenGraphAndOEmbedTags methods that share some code

@kimsible kimsible force-pushed the feat/share-account-and-channel branch from 9cfca56 to ae174d8 Compare July 26, 2020 21:41
@Chocobozzz
Copy link
Owner

Please fix lint tests and https://travis-ci.com/github/Chocobozzz/PeerTube/jobs/365185689 test

@kimsible
Copy link
Contributor Author

Please fix lint tests and https://travis-ci.com/github/Chocobozzz/PeerTube/jobs/365185689 test

I'll try but the tests still not work in local, maybe I should open an issue, it's a serious problem for contributions...

@Chocobozzz
Copy link
Owner

I'll try but the tests still not work in local, maybe I should open an issue, it's a serious problem for contributions...

Yes please

@kimsible
Copy link
Contributor Author

Could you add tests for accounts, channels and playlists meta tags? https://github.com/Chocobozzz/PeerTube/blob/develop/server/tests/client.

I"ve added some tests, but I still have this problem with local tests #3022

Maybe you could also refactor addAccountOrChannelOpenGraphAndMetaTags, addVideoPlaylistOpenGraphAndMetaTags and addVideoOpenGraphAndOEmbedTags methods that share some code

I've refactored all these methods.

@Chocobozzz
Copy link
Owner

Thanks

@Chocobozzz Chocobozzz merged commit 8d987ec into Chocobozzz:develop Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta image and description sharing account or channel url
2 participants