Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remote interaction on accounts #5977

Open
alexlehm opened this issue Sep 18, 2023 · 3 comments
Open

Support remote interaction on accounts #5977

alexlehm opened this issue Sep 18, 2023 · 3 comments
Labels
Component: Subscriptions Status: Blocked ✋ Somehow, somewhere *else*, something has gone very wrong. Until they fix it we're stuck. Type: Feature Request ✨

Comments

@alexlehm
Copy link

Describe the current behavior

When clicking remote follow on an account page, the local instance gives an error "Cannot access to the remote resource"

__

Steps to reproduce

  1. go to a remote peertube account page (e.g. I used https://makertube.net/a/jan_beta/video-channels)
  2. click on subscribe to all channels, subscribe with remote account (I used my account alexlehm@cliptube.org)
  3. the resulting url https://cliptube.org/remote-interaction?uri=https:%2F%2Fmakertube.net%2Faccounts%2Fjan_beta gives "Cannot access to the remote resource"

Describe the expected behavior

I would expect the target url to show the remote account in the local domain and show the subscribe with your local account option

Additional information

  • PeerTube instance:

  • Browser name, version and platforms on which you could reproduce the bug: Firefox 117.0.1, Windows 10

  • Link to browser console log if relevant:

  • Link to server log if relevant (journalctl or /var/www/peertube/storage/logs/):

@wickloww wickloww added Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor Component: Subscriptions labels Sep 19, 2023
@wickloww
Copy link
Collaborator

Hi there,
In the code I actually see that the redirect searches videos and channels, but not accounts. The API is missing an endpoint to search in accounts. We'd need to add that endpoint for this behavior to work.
https://github.com/Chocobozzz/PeerTube/blob/a1d93180668a265d5f7bc595e8e864db10e356b6/client/src/app/%2Bremote-interaction/remote-interaction.component.ts#L31C34-L31C34

@alexlehm
Copy link
Author

ok, switching to the channel from the account and then clicking remote follow works apparently.

i will use that, thanks

@Chocobozzz
Copy link
Owner

Thanks, workaround implemented in 5cea8f9 where we hide remote interaction on accounts. This is not ideal, since Mastodon users (for example) can remote interact on accounts.

We need to implement remote interaction on accounts, but #3316 has to be resolved first.

@Chocobozzz Chocobozzz added Type: Feature Request ✨ and removed Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor labels Oct 3, 2023
@Chocobozzz Chocobozzz changed the title Remote follow for accounts does not work between instances Support remote interaction on accounts Oct 3, 2023
@Chocobozzz Chocobozzz added the Status: Blocked ✋ Somehow, somewhere *else*, something has gone very wrong. Until they fix it we're stuck. label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Subscriptions Status: Blocked ✋ Somehow, somewhere *else*, something has gone very wrong. Until they fix it we're stuck. Type: Feature Request ✨
Projects
None yet
Development

No branches or pull requests

3 participants