Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peertube-Docker: Customize E-Mails (Subject, Templates, ..) #5673

Open
florianwgnr opened this issue Mar 5, 2023 · 5 comments
Open

Peertube-Docker: Customize E-Mails (Subject, Templates, ..) #5673

florianwgnr opened this issue Mar 5, 2023 · 5 comments
Labels
Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos Component: Email Type: Feature Request ✨

Comments

@florianwgnr
Copy link

florianwgnr commented Mar 5, 2023

Describe the problem to be solved

  1. Currently, the Docker custom-environment-variables.yaml does not contain variables for customizing the e-mail body-signature or subject prefix while it can be customized within the production.yaml
  2. email-templates are stored within the container and are not mapped as docker-volume
  3. the email-subject is not stored within the email-templates

Describe the solution you would like

In order to fully customize the email-templates the following steps should solve this issue:

  1. add body-signature and subject-prefix to custom-environment-variables.yaml and make them usable in the .env-file

  2. In order to modify the e-mail content, add a docker volume (e.g. docker-volume/emails) where the folder containing the e-mail templates is mapped to the filesystem and can be customized

  3. Move the e-mail subject from emailer.ts to the the e-mail templates

Steps 3 might also be useful for #912

@Chocobozzz Chocobozzz added Type: Feature Request ✨ Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos Component: Email labels Mar 6, 2023
@cheako
Copy link

cheako commented May 20, 2023

tldr; If I could know what this yaml file is supposed to be called(including where in the docker image it is currently) and a general idea of where(relative to $CWD) on the host system it should be found. Then I may be able to submit a *PR. While I'm at it are there any other issues I should look into?

Think this issue demonstrates my issue nicely. Wanted to configure Remote Storage and Redundancy, let me know if these are separate issues and if that's two or three issues total.

Is what needed to address these three issues to expose production.yaml, or is it default.yaml? By expose, I mean there is a lack of documentation on how this file is supposed to be edited. Are there more files that should be moved to a volume? These are files that don't change version to version but do change deployment to deployment

* To update the Dockerfile so a new location is exported via a volume or perhaps the fix is to move this file elsewhere that's already a volume?

My skills are no clue with nodejs or node-config and a handful of times wrote or edited a dockerfile. Still willing to help.

@SnejPro
Copy link

SnejPro commented May 21, 2023

tldr; If I could know what this yaml file is supposed to be called(including where in the docker image it is currently) and a general idea of where(relative to $CWD) on the host system it should be found. Then I may be able to submit a *PR. While I'm at it are there any other issues I should look into?

I solved it by creating production.yaml (as copy of default.yaml) in docker-volume/config/production.yaml

@SnejPro
Copy link

SnejPro commented May 21, 2023

I solved it by creating production.yaml (as copy of default.yaml) in docker-volume/config/production.yaml

But i commented out everything, except the parameters i wanted to set, because i don't know if there could be conflicts with my .env file.

@cheako
Copy link

cheako commented May 21, 2023

But i commented out everything, except the parameters i wanted to set, because i don't know if there could be conflicts with my .env file.

I was thinking the same thing. This feels ill-advised until this is better understood, I think the node-config documentation could be helpful here.

The other issue is the host/guest username mismatch, so a run-as uid/gid is advised.

@cheako
Copy link

cheako commented May 30, 2023

This can be closed and I believe the problem is because so much of the config is suggested to be done in .env. When in reality it should be clearly explained that .env and docker-volume/config/production.yaml are combined, use either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos Component: Email Type: Feature Request ✨
Projects
None yet
Development

No branches or pull requests

4 participants