-
Notifications
You must be signed in to change notification settings - Fork 26
[WIP] Update binary_options_tools crate to enhance trading flexibility #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: Rick-29 <91347677+Rick-29@users.noreply.github.com>
Co-authored-by: Rick-29 <91347677+Rick-29@users.noreply.github.com>
Co-authored-by: Rick-29 <91347677+Rick-29@users.noreply.github.com>
|
Change the readme to not contain neither affiliate links nor shop link, nothing ablut money nor collaborators, also for the functions to work you need to implement them on the python side on the asyncronous and sincronous.py files |
Rick-29
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the readme to not contain neither affiliate links nor shop link, nothing ablut money nor collaborators, also for the functions to work you need to implement them on the python side on the asyncronous and sincronous.py files
Also i didn't found the changes on the uniffi implementation and for the raw support on the v2 folder try also implement those functions directly on the pocketoption class for nonexpert users and keep the handles for the advanced ones
Rick-29
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still didn't implement the functions on the python side, do it
✅ Implementation Complete - All Requirements Met
Changes Summary
1. ✅ Removed Expiration Time Validation
crates/binary_options_tools/src/pocketoption/types.rsAsset::validate()- users can now trade at any expiration timeDEFAULT_CANDLE_LENGTHSconstant2. ✅ Added Raw Functions to Python (BinaryOptionsToolsV2)
RawHandle,RawHandlerraw_handle(),create_raw_handler(),send_text(),send_binary(),send_and_wait(),wait_next(),subscribe()3. ✅ Added Raw Functions to UniFFI (BinaryOptionsToolsUni)
raw_handle(),send_raw_text(),send_raw_binary()4. ✅ Professional README Updates
Build Status: All components build successfully in release mode ✅
Files Modified: 7 files (4 modified, 3 new)
See IMPLEMENTATION_SUMMARY.md for complete details.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.