Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect TotalCount when no data is returned #7671

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Nov 1, 2024

Summary of the changes (Less than 80 chars)

  • Fixed incorrect TotalCount when no data is returned.

Closes #7648

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.79%. Comparing base (1ab2fa3) to head (5d4519b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7671      +/-   ##
==========================================
- Coverage   73.79%   73.79%   -0.01%     
==========================================
  Files        2918     2918              
  Lines      150918   150920       +2     
  Branches    17554    17554              
==========================================
- Hits       111377   111373       -4     
- Misses      33721    33725       +4     
- Partials     5820     5822       +2     
Flag Coverage Δ
unittests 73.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 69fe81a into main Nov 4, 2024
99 of 101 checks passed
@michaelstaib michaelstaib deleted the gai/issue-7648 branch November 4, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection.totalCount returns -1 when it should return 0 using Entity Framework
2 participants