Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced unnecessary snapshots #7465

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Reduced unnecessary snapshots #7465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3870594
Reduced unnecessary snapshots
glen-84 Sep 16, 2024
c94614c
Merge branch 'main' into gai/reduce-unnecessary-snapshots
glen-84 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion src/CookieCrumble/src/CookieCrumble/Extensions/SnapshotExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ public static Snapshot AddResult(
string.IsNullOrEmpty(name)
? "Result:"
: $"{name} Result:");
snapshot.SetPostFix(TestEnvironment.TargetFramework);

if (result.ContextData.TryGetValue("query", out var queryResult) &&
queryResult is string queryString &&
Expand Down
15 changes: 0 additions & 15 deletions ...ots__/EntityFrameworkResolverCompilerIntegrationTests.DBContext_On_Queries_Is_Scoped.snap
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ...t/Data.EntityFramework.Tests/__snapshots__/UseDbContextTests.DbContextType_Is_Object.snap
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions ....Tests/__snapshots__/UseDbContextTests.DbContext_ResolverExtension_Missing_DbContext.snap
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...HotChocolate/Data/test/Data.Filters.SqlServer.Tests/QueryableFilterVisitorBooleanTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public async Task Create_NullableBooleanNotEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "true")
.AddResult(res2, "false")
.AddResult(res3, "null")
Expand Down
10 changes: 5 additions & 5 deletions ...Chocolate/Data/test/Data.Filters.SqlServer.Tests/QueryableFilterVisitorComparableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ public async Task Create_ShortIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "12and13")
.AddResult(res2, "13and14")
.AddResult(res3, "nullAnd14")
Expand Down Expand Up @@ -435,7 +435,7 @@ public async Task Create_ShortNotIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "12and13")
.AddResult(res2, "13and14")
.AddResult(res3, "nullAnd14")
Expand Down Expand Up @@ -497,7 +497,7 @@ public async Task Create_ShortNullableNotEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "12")
.AddResult(res2, "13")
.AddResult(res3, "null")
Expand Down Expand Up @@ -824,7 +824,7 @@ public async Task Create_ShortNullableIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "12and13")
.AddResult(res2, "13and14")
.AddResult(res3, "13andNull")
Expand Down Expand Up @@ -855,7 +855,7 @@ public async Task Create_ShortNullableNotIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "12and13")
.AddResult(res2, "13and14")
.AddResult(res3, "13andNull")
Expand Down
10 changes: 5 additions & 5 deletions src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/QueryableFilterVisitorEnumTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public async Task Create_EnumIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "BarAndFoo")
.AddResult(res2, "FOO")
.AddResult(res3, "nullAndFoo")
Expand Down Expand Up @@ -141,7 +141,7 @@ public async Task Create_EnumNotIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "BarAndFoo")
.AddResult(res2, "FOO")
.AddResult(res3, "nullAndFoo")
Expand Down Expand Up @@ -204,7 +204,7 @@ public async Task Create_NullableEnumNotEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "BAR")
.AddResult(res2, "FOO")
.AddResult(res3, "null")
Expand Down Expand Up @@ -235,7 +235,7 @@ public async Task Create_NullableEnumIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "BarAndFoo")
.AddResult(res2, "FOO")
.AddResult(res3, "nullAndFoo")
Expand Down Expand Up @@ -266,7 +266,7 @@ public async Task Create_NullableEnumNotIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "BarAndFoo")
.AddResult(res2, "FOO")
.AddResult(res3, "nullAndFoo")
Expand Down
2 changes: 1 addition & 1 deletion ...Chocolate/Data/test/Data.Filters.SqlServer.Tests/QueryableFilterVisitorExpressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public async Task Create_StringConcatExpression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "Sam_Sampleman")
.AddResult(res2, "NoMatch")
.AddResult(res3, "null")
Expand Down
8 changes: 4 additions & 4 deletions src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/QueryableFilterVisitorListTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public async Task Create_ArraySomeObjectStringEqualWithNull_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "a")
.AddResult(res2, "d")
.AddResult(res3, "null")
Expand Down Expand Up @@ -131,7 +131,7 @@ public async Task Create_ArrayNoneObjectStringEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "a")
.AddResult(res2, "d")
.AddResult(res3, "null")
Expand Down Expand Up @@ -165,7 +165,7 @@ public async Task Create_ArrayAllObjectStringEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "a")
.AddResult(res2, "d")
.AddResult(res3, "null")
Expand Down Expand Up @@ -199,7 +199,7 @@ public async Task Create_ArrayAnyObjectStringEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "false")
.AddResult(res2, "true")
.AddResult(res3, "null")
Expand Down
14 changes: 7 additions & 7 deletions src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/QueryableFilterVisitorObjectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public async Task Create_ObjectShortIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "12and13")
.AddResult(res2, "13and14")
.AddResult(res3, "nullAnd14")
Expand Down Expand Up @@ -248,7 +248,7 @@ public async Task Create_ObjectNullableShortIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "12and13")
.AddResult(res2, "13and14")
.AddResult(res3, "13andNull")
Expand Down Expand Up @@ -388,7 +388,7 @@ public async Task Create_ObjectEnumIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "BarAndFoo")
.AddResult(res2, "FOO")
.AddResult(res3, "nullAndFoo")
Expand Down Expand Up @@ -463,7 +463,7 @@ public async Task Create_ObjectNullableEnumIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "BarAndFoo")
.AddResult(res2, "FOO")
.AddResult(res3, "nullAndFoo")
Expand Down Expand Up @@ -537,7 +537,7 @@ public async Task Create_ObjectStringIn_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "testatestAndtestb")
.AddResult(res2, "testbtestAndNull")
.AddResult(res3, "testatest")
Expand Down Expand Up @@ -577,7 +577,7 @@ public async Task Create_ArrayObjectNestedArraySomeStringEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "a")
.AddResult(res2, "b")
.AddResult(res3, "null")
Expand Down Expand Up @@ -614,7 +614,7 @@ public async Task Create_ArrayObjectNestedArrayAnyStringEqual_Expression()

// assert
await Snapshot
.Create()
.Create(postFix: TestEnvironment.TargetFramework)
.AddResult(res1, "false")
.AddResult(res2, "true")
.AddResult(res3, "null")
Expand Down
Loading
Loading