Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inlining of total count when using cursor pagination. #7366

Merged
merged 22 commits into from
Aug 15, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 163 lines in your changes missing coverage. Please review.

Project coverage is 72.25%. Comparing base (da14f3b) to head (3d5de77).
Report is 1 commits behind head on main.

Files Patch % Lines
...ework/Pagination/EfQueryableCursorPagingHandler.cs 76.42% 33 Missing ⚠️
...yFramework/Extensions/PagingQueryableExtensions.cs 68.13% 29 Missing ⚠️
...re/src/Abstractions/DefaultEnumerableExecutable.cs 0.00% 17 Missing ⚠️
...c/Abstractions/DefaultAsyncEnumerableExecutable.cs 0.00% 11 Missing ⚠️
...goDb/src/Data/Paging/MongoDbCursorPagingHandler.cs 65.62% 11 Missing ⚠️
...rk/Properties/EntityFrameworkResources.Designer.cs 0.00% 9 Missing ⚠️
...c/Pagination.Core/Expressions/ExpressionHelpers.cs 91.30% 8 Missing ⚠️
...Extensions/RavenCursorPagingQueryableExtensions.cs 74.07% 7 Missing ⚠️
...ore/src/Abstractions/DefaultQueryableExecutable.cs 50.00% 6 Missing ⚠️
...ntityFramework/Pagination/EfQueryableExecutable.cs 70.58% 5 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7366      +/-   ##
==========================================
- Coverage   77.31%   72.25%   -5.07%     
==========================================
  Files        2475     2792     +317     
  Lines      122805   139440   +16635     
==========================================
+ Hits        94952   100756    +5804     
- Misses      27853    38684   +10831     
Flag Coverage Δ
unittests 72.25% <80.00%> (-5.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 74660d6 into main Aug 15, 2024
119 of 131 checks passed
@michaelstaib michaelstaib deleted the mst/paging-improvements branch August 15, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants