Allow to incrementally adopt new ID format in distributed system#7343
Merged
michaelstaib merged 2 commits intomainfrom Aug 10, 2024
Merged
Allow to incrementally adopt new ID format in distributed system#7343michaelstaib merged 2 commits intomainfrom
michaelstaib merged 2 commits intomainfrom
Conversation
6661104 to
1bc5893
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7343 +/- ##
==========================================
- Coverage 77.06% 76.61% -0.45%
==========================================
Files 2460 2786 +326
Lines 122123 139089 +16966
==========================================
+ Hits 94108 106559 +12451
- Misses 28015 32530 +4515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to adopt the new ID format in a distributed system, you need to
Currently this adoption strategy wouldn't be possible, because while the new Default Serializer supports parsing both formats, it only outputs the new format, making it impossible to only update one service. The Legacy serializer only handles the old format, so it also can't be used to start adopting the new format.
This PR introduces a new option
outputNewIdFormatforAddDefaultNodeIdSerializer. This allows you in the first step to update all your services toAddDefaultNodeIdSerializer(outputNewIdFormat: false)and once all services are updated, switch to outputting the new ID format viaAddDefaultNodeIdSerializer().