Resolve issue where an Entity is required in subgraphs and remove non-resolvable from _entity output #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielreynolds1
commented
Jun 12, 2024
|
|
||
| public class TestTypePropertyDirectives | ||
| { | ||
| [Key(null!, resolvable: false)] |
There was a problem hiding this comment.
Is this a desirable syntax? Should resolvable be unsupported when specified on a field set?
A question for maintainers/Apollo
There was a problem hiding this comment.
Hi @michaelstaib, if you could have a small think about this comment, it would be appreciated. Once decision has been made/changes implemented, the rest can be reviewed a bit later. Thanks!
danielreynolds1
force-pushed
the
personal/dr/non-resolvable-key
branch
from
92a5616
to
076cdde
Compare
michaelstaib
force-pushed
the
main
branch
2 times, most recently
from
8a97a79
to
e2d2300
Compare
danielreynolds1
force-pushed
the
personal/dr/non-resolvable-key
branch
from
d9a1127
to
bd63086
Compare
|
I will have a look today ... sorry for the wait |
michaelstaib
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HotChocolate 13.9+, entities are required to be present in a subgraph, but as per the attached issue, this isn't required to be the case. I also had a review of non-resolvable key behaviours.
Summary of the changes:
Subgraphs will now compile and run even if they don't contain any entities.
@key(resolvable: false) will no longer add the entity to the _entities union (see here).
Tests have been amended for these.
Closes #6900