Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DI Support #6994

Merged
merged 8 commits into from
Mar 19, 2024
Merged

Simplify DI Support #6994

merged 8 commits into from
Mar 19, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

github-actions bot commented Mar 19, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 58.66667% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 69.96%. Comparing base (717ded9) to head (dfcd21a).

❗ Current head dfcd21a differs from pull request most recent head 3f3f805. Consider uploading reports for the commit 3f3f805 to get more accurate results

Files Patch % Lines
...ypes/Extensions/ObjectFieldDescriptorExtensions.cs 0.00% 22 Missing ⚠️
src/HotChocolate/Core/src/Types/SchemaOptions.cs 0.00% 6 Missing ⚠️
...ate/Core/src/Execution/Processing/WorkScheduler.cs 50.00% 2 Missing ⚠️
...sions/ProjectionObjectFieldDescriptorExtensions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6994      +/-   ##
==========================================
- Coverage   72.84%   69.96%   -2.89%     
==========================================
  Files        2592     2578      -14     
  Lines      129417   128926     -491     
==========================================
- Hits        94276    90197    -4079     
- Misses      35141    38729    +3588     
Flag Coverage Δ
unittests 69.96% <58.66%> (-2.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 4450784 into main Mar 19, 2024
7 of 10 checks passed
@michaelstaib michaelstaib deleted the mst/di-refactoring branch March 19, 2024 08:18
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant