Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circular reference validation rules in input types #6821

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

AntonC9018
Copy link
Contributor

Closes #285

Copy link

github-actions bot commented Jan 16, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (34c343c) 70.92% compared to head (d45d584) 70.86%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ration/Validation/InputObjectTypeValidationRule.cs 64.70% 12 Missing ⚠️
...tChocolate/Core/src/Types/Utilities/ErrorHelper.cs 27.27% 8 Missing ⚠️
...ore/src/Types/Properties/TypeResources.Designer.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6821      +/-   ##
==========================================
- Coverage   70.92%   70.86%   -0.07%     
==========================================
  Files        2520     2520              
  Lines      126602   126602              
==========================================
- Hits        89793    89716      -77     
- Misses      36809    36886      +77     
Flag Coverage Δ
unittests 70.86% <52.08%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit a5f0039 into main Jan 16, 2024
88 of 98 checks passed
@michaelstaib michaelstaib deleted the anton/circular-ref-validation-285 branch January 16, 2024 11:25
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rules for how circular references in Input Objects are handled
2 participants