Attempt fixing nested variable forwarding in Fusion

[martindisch]

With a query containing nested fields with arguments such as

query ProductReviews(
  $id: ID!
  $first: Int
) {
  node(id: $id) {
    ... on Product {
      id
      reviews(first: $first) {
        body
      }
    }
  }
}

the variables going to the nested fields (in this case $first) don't get forwarded to the subgraph, because while resolving the requirements the request formatter only considers the variables of the top-level field of the current selection (node), not those of its children.
The gateway returns the error "The following variables were not declared: first." originating from the subgraph missing its variable.

This can be "fixed" by the change in this PR, although it's definitely not a sensible solution. Do you have any ideas as to the proper way of dealing with that?

[michaelstaib]

This fix is not the solution ... I am working on a proper fix at the moment ...

[martindisch]

Excellent, that's what we've been hoping for! Feel free to close this once you have something.

[michaelstaib]

I have found a couple more cases that were not working ... like nested variables and so on. We will ship the fix with 13.2.1 today.

[michaelstaib]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[michaelstaib]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[michaelstaib]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

0.0% Coverage
11.3% Duplication

[martindisch]

Great stuff, thanks for the proper fix!