-
-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt fixing nested variable forwarding in Fusion #6119
Merged
michaelstaib
merged 7 commits into
ChilliCream:main
from
martindisch:fix-variable-forwarding
Jun 5, 2023
Merged
Attempt fixing nested variable forwarding in Fusion #6119
michaelstaib
merged 7 commits into
ChilliCream:main
from
martindisch:fix-variable-forwarding
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindisch
changed the title
Attempt fixing nested variable forwarding
Attempt fixing nested variable forwarding in Fusion
May 5, 2023
This fix is not the solution ... I am working on a proper fix at the moment ... |
Excellent, that's what we've been hoping for! Feel free to close this once you have something. |
I have found a couple more cases that were not working ... like nested variables and so on. We will ship the fix with 13.2.1 today. |
michaelstaib
approved these changes
Jun 5, 2023
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
SonarCloud Quality Gate failed. |
Great stuff, thanks for the proper fix! |
This was referenced Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a query containing nested fields with arguments such as
the variables going to the nested fields (in this case
$first
) don't get forwarded to the subgraph, because while resolving the requirements the request formatter only considers the variables of the top-level field of the current selection (node
), not those of its children.The gateway returns the error "The following variables were not declared: first." originating from the subgraph missing its variable.
This can be "fixed" by the change in this PR, although it's definitely not a sensible solution. Do you have any ideas as to the proper way of dealing with that?