Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutation Conventions #4519

Merged
merged 32 commits into from
Dec 8, 2021
Merged

Mutation Conventions #4519

merged 32 commits into from
Dec 8, 2021

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Dec 2, 2021 •
edited
Loading

@PascalSenn PascalSenn linked an issue Dec 2, 2021 that may be closed by this pull request
Input Object Type argument created by Input helper is nullable #4517
Closed
1 task
@michaelstaib
Copy link
Member Author

I have reworked how we handle arguments so that all schema-building approaches are aligned. With the new approach, we rewrite the arguments in field middleware. This allows us to have the resolver code act if there was no input type at all.
This will cause allocation for two dictionaries for each mutation field. Since in general, we will not have more than a couple of mutation fields per request this should be OK. We can always rent these if the need would arise.

@michaelstaib michaelstaib added this to the HC-12.4.0 milestone Dec 7, 2021
@michaelstaib michaelstaib merged commit f77a2be into main Dec 8, 2021
@michaelstaib michaelstaib deleted the mst/mutationConventions branch December 8, 2021 11:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

85.8% 85.8% Coverage
0.0% 0.0% Duplication

@renovate renovate bot mentioned this pull request Dec 14, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalSenn PascalSenn PascalSenn left review comments

Assignees
No one assigned
Labels
🌶️ hot chocolate 🌶️ website
Projects
None yet
Milestone
HC-12.4.0
Development

Successfully merging this pull request may close these issues.

Input Object Type argument created by Input helper is nullable
2 participants
@michaelstaib @PascalSenn