Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed default values of enums #4129

Merged
merged 5 commits into from
Aug 27, 2021
Merged

Fixed default values of enums #4129

merged 5 commits into from
Aug 27, 2021

Conversation

PascalSenn
Copy link
Member

Closes #1862

@PascalSenn PascalSenn added the 👓 ready-for-review The PR is ready for review. label Aug 24, 2021
@PascalSenn
Copy link
Member Author

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@michaelstaib
Copy link
Member

@PascalSenn I reverted your change and fixed it in the TypeDependencyHelper. The TypeDependencyHelper is the class responsible for collecting the type dependencies for the type initialization. This is the central component defining the kind of dependency.

@michaelstaib michaelstaib merged commit 49bec1b into develop Aug 27, 2021
@michaelstaib michaelstaib deleted the pse/fix-default-value-enum branch August 27, 2021 14:41
@SleeplessOne1917 SleeplessOne1917 mentioned this pull request Sep 10, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ hot chocolate 👓 ready-for-review The PR is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to define enum default value on an input type
2 participants
@PascalSenn @michaelstaib