From 0154f8b3c3a3be9fd25112b87192ad5ee7fc8f9d Mon Sep 17 00:00:00 2001
From: Glen <glen.84@gmail.com>
Date: Mon, 15 Jul 2024 09:57:11 +0200
Subject: [PATCH] Enabled TreatWarningsAsErrors in CI, and disabled it
 elsewhere (#7263)

---
 src/Directory.Build.props                           | 13 ++++---------
 src/GreenDonut/test/Directory.Build.props           |  1 -
 .../ApolloFederation/test/Directory.Build.props     |  1 -
 .../AspNetCore/test/Directory.Build.props           |  1 -
 .../AzureFunctions/test/Directory.Build.props       |  1 -
 src/HotChocolate/Caching/test/Directory.Build.props |  1 -
 .../Abstractions/HotChocolate.Abstractions.csproj   |  2 --
 .../HotChocolate.Types.NodaTime.csproj              |  1 -
 .../Types.Shared/HotChocolate.Types.Shared.csproj   |  4 ----
 src/HotChocolate/Core/test/Directory.Build.props    |  1 -
 .../HotChocolate.Types.NodaTime.Tests.csproj        |  1 -
 .../CostAnalysis/test/Directory.Build.props         |  1 -
 src/HotChocolate/Data/Directory.Build.props         |  2 --
 .../HotChocolate.Data.Projections.Tests.csproj      |  2 --
 .../HotChocolate.Data.Sorting.InMemory.Tests.csproj |  2 --
 .../HotChocolate.Data.Sorting.Tests.csproj          |  1 -
 .../test/Data.Tests/HotChocolate.Data.Tests.csproj  |  2 --
 src/HotChocolate/Data/test/Directory.Build.props    |  1 -
 .../Diagnostics/test/Directory.Build.props          |  1 -
 .../Fusion/src/Core/HotChocolate.Fusion.csproj      |  2 --
 src/HotChocolate/Fusion/src/Directory.Build.props   |  2 --
 src/HotChocolate/Fusion/test/Directory.Build.props  |  1 -
 .../Language/test/Directory.Build.props             |  1 -
 src/HotChocolate/Marten/Directory.Build.props       |  2 --
 src/HotChocolate/Marten/test/Directory.Build.props  |  1 -
 src/HotChocolate/MongoDb/Directory.Build.props      |  2 --
 src/HotChocolate/MongoDb/test/Directory.Build.props |  1 -
 src/HotChocolate/OpenApi/test/Directory.Build.props |  1 -
 src/HotChocolate/Pagination/Directory.Build.props   |  2 --
 .../Pagination/test/Directory.Build.props           |  1 -
 .../PersistedQueries/test/Directory.Build.props     |  1 -
 .../Primitives/src/Directory.Build.props            |  3 ---
 .../Primitives/test/Directory.Build.props           |  1 -
 src/HotChocolate/Raven/Directory.Build.props        |  2 --
 src/HotChocolate/Raven/test/Directory.Build.props   |  1 -
 src/HotChocolate/Skimmed/test/Directory.Build.props |  1 -
 src/HotChocolate/Spatial/Directory.Build.props      |  2 --
 src/HotChocolate/Spatial/test/Directory.Build.props |  1 -
 .../Utilities/test/Directory.Build.props            |  1 -
 .../Client/test/Directory.Build.props               |  1 -
 .../CodeGeneration/test/Directory.Build.props       |  1 -
 .../Tooling/test/Directory.Build.props              |  1 -
 42 files changed, 4 insertions(+), 67 deletions(-)

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index acf9dd66649..4033eddeff0 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -3,19 +3,14 @@
   <PropertyGroup>
     <LangVersion>preview</LangVersion>
     <Version Condition="$(Version) == ''">0.0.0</Version>
-    <NoWarn>$(NoWarn);CS0436;RS0026;RS0027;RS0041;AD0001;CS1591;NU5104;NU5128;NU5501;NU1902;NU1903;NU1904</NoWarn>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)' == 'debug'">
+    <NoWarn>$(NoWarn);CS0436;RS0026;RS0027;RS0041;AD0001;CS1591;NU5104;NU5128;NU5501</NoWarn>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)' == 'release'">
-    <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+  <PropertyGroup Condition="'$(CI)' == 'true'">
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
+    <WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/GreenDonut/test/Directory.Build.props b/src/GreenDonut/test/Directory.Build.props
index 46c6285fe48..bbd034619eb 100644
--- a/src/GreenDonut/test/Directory.Build.props
+++ b/src/GreenDonut/test/Directory.Build.props
@@ -5,7 +5,6 @@
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/ApolloFederation/test/Directory.Build.props b/src/HotChocolate/ApolloFederation/test/Directory.Build.props
index 176c14c0a30..058ed278104 100644
--- a/src/HotChocolate/ApolloFederation/test/Directory.Build.props
+++ b/src/HotChocolate/ApolloFederation/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/AspNetCore/test/Directory.Build.props b/src/HotChocolate/AspNetCore/test/Directory.Build.props
index 62f02755cc1..1a69a93e073 100644
--- a/src/HotChocolate/AspNetCore/test/Directory.Build.props
+++ b/src/HotChocolate/AspNetCore/test/Directory.Build.props
@@ -6,7 +6,6 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/AzureFunctions/test/Directory.Build.props b/src/HotChocolate/AzureFunctions/test/Directory.Build.props
index 29abb2d0ee3..40d24d34432 100644
--- a/src/HotChocolate/AzureFunctions/test/Directory.Build.props
+++ b/src/HotChocolate/AzureFunctions/test/Directory.Build.props
@@ -5,7 +5,6 @@
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Caching/test/Directory.Build.props b/src/HotChocolate/Caching/test/Directory.Build.props
index acddd8ccf6e..bd83f78de3a 100644
--- a/src/HotChocolate/Caching/test/Directory.Build.props
+++ b/src/HotChocolate/Caching/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Core/src/Abstractions/HotChocolate.Abstractions.csproj b/src/HotChocolate/Core/src/Abstractions/HotChocolate.Abstractions.csproj
index 5fc69ade1cc..f596f7c0330 100644
--- a/src/HotChocolate/Core/src/Abstractions/HotChocolate.Abstractions.csproj
+++ b/src/HotChocolate/Core/src/Abstractions/HotChocolate.Abstractions.csproj
@@ -10,8 +10,6 @@
   <PropertyGroup>
     <Nullable>enable</Nullable>
     <EnableTrimAnalyzer Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</EnableTrimAnalyzer>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
diff --git a/src/HotChocolate/Core/src/Types.NodaTime/HotChocolate.Types.NodaTime.csproj b/src/HotChocolate/Core/src/Types.NodaTime/HotChocolate.Types.NodaTime.csproj
index 9fdfdeec4e5..3f2e1f46e93 100644
--- a/src/HotChocolate/Core/src/Types.NodaTime/HotChocolate.Types.NodaTime.csproj
+++ b/src/HotChocolate/Core/src/Types.NodaTime/HotChocolate.Types.NodaTime.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Nullable>enable</Nullable>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
diff --git a/src/HotChocolate/Core/src/Types.Shared/HotChocolate.Types.Shared.csproj b/src/HotChocolate/Core/src/Types.Shared/HotChocolate.Types.Shared.csproj
index a258766f92f..bfeda281d5f 100644
--- a/src/HotChocolate/Core/src/Types.Shared/HotChocolate.Types.Shared.csproj
+++ b/src/HotChocolate/Core/src/Types.Shared/HotChocolate.Types.Shared.csproj
@@ -10,10 +10,6 @@
 <PropertyGroup>
   <Nullable>enable</Nullable>
   <ImplicitUsings>enable</ImplicitUsings>
-  
-  <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-  <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-
   <EnableTrimAnalyzer Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</EnableTrimAnalyzer>
   <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</IsTrimmable>
 </PropertyGroup>
diff --git a/src/HotChocolate/Core/test/Directory.Build.props b/src/HotChocolate/Core/test/Directory.Build.props
index fca9dc19569..2f395aa59c0 100644
--- a/src/HotChocolate/Core/test/Directory.Build.props
+++ b/src/HotChocolate/Core/test/Directory.Build.props
@@ -5,7 +5,6 @@
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Core/test/Types.NodaTime.Tests/HotChocolate.Types.NodaTime.Tests.csproj b/src/HotChocolate/Core/test/Types.NodaTime.Tests/HotChocolate.Types.NodaTime.Tests.csproj
index db70606fff2..0085615d454 100644
--- a/src/HotChocolate/Core/test/Types.NodaTime.Tests/HotChocolate.Types.NodaTime.Tests.csproj
+++ b/src/HotChocolate/Core/test/Types.NodaTime.Tests/HotChocolate.Types.NodaTime.Tests.csproj
@@ -4,7 +4,6 @@
     <AssemblyName>HotChocolate.Types.NodaTime.Tests</AssemblyName>
     <RootNamespace>HotChocolate.Types.NodaTime</RootNamespace>
     <Nullable>enable</Nullable>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/CostAnalysis/test/Directory.Build.props b/src/HotChocolate/CostAnalysis/test/Directory.Build.props
index bd3462577c9..4e9f57a4a3a 100644
--- a/src/HotChocolate/CostAnalysis/test/Directory.Build.props
+++ b/src/HotChocolate/CostAnalysis/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Data/Directory.Build.props b/src/HotChocolate/Data/Directory.Build.props
index 6a85a251082..19230d32ad7 100644
--- a/src/HotChocolate/Data/Directory.Build.props
+++ b/src/HotChocolate/Data/Directory.Build.props
@@ -5,8 +5,6 @@
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
     <Nullable>enable</Nullable>
     <NoWarn>$(NoWarn);CA1062</NoWarn>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NeutralLanguage>en</NeutralLanguage>
     <ImplicitUsings>enable</ImplicitUsings>
 
diff --git a/src/HotChocolate/Data/test/Data.Projections.Tests/HotChocolate.Data.Projections.Tests.csproj b/src/HotChocolate/Data/test/Data.Projections.Tests/HotChocolate.Data.Projections.Tests.csproj
index 4c04cebe5f6..d4fc6b6ded4 100644
--- a/src/HotChocolate/Data/test/Data.Projections.Tests/HotChocolate.Data.Projections.Tests.csproj
+++ b/src/HotChocolate/Data/test/Data.Projections.Tests/HotChocolate.Data.Projections.Tests.csproj
@@ -3,8 +3,6 @@
   <PropertyGroup>
     <AssemblyName>HotChocolate.Data.Projections.Tests</AssemblyName>
     <RootNamespace>HotChocolate.Data</RootNamespace>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Data/test/Data.Sorting.InMemory.Tests/HotChocolate.Data.Sorting.InMemory.Tests.csproj b/src/HotChocolate/Data/test/Data.Sorting.InMemory.Tests/HotChocolate.Data.Sorting.InMemory.Tests.csproj
index a4857e63309..b0e56c253e8 100644
--- a/src/HotChocolate/Data/test/Data.Sorting.InMemory.Tests/HotChocolate.Data.Sorting.InMemory.Tests.csproj
+++ b/src/HotChocolate/Data/test/Data.Sorting.InMemory.Tests/HotChocolate.Data.Sorting.InMemory.Tests.csproj
@@ -3,8 +3,6 @@
   <PropertyGroup>
     <AssemblyName>HotChocolate.Data.Sorting.InMemory.Tests</AssemblyName>
     <RootNamespace>HotChocolate.Data</RootNamespace>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Data/test/Data.Sorting.Tests/HotChocolate.Data.Sorting.Tests.csproj b/src/HotChocolate/Data/test/Data.Sorting.Tests/HotChocolate.Data.Sorting.Tests.csproj
index 93821f56d76..2b1d295f6f3 100644
--- a/src/HotChocolate/Data/test/Data.Sorting.Tests/HotChocolate.Data.Sorting.Tests.csproj
+++ b/src/HotChocolate/Data/test/Data.Sorting.Tests/HotChocolate.Data.Sorting.Tests.csproj
@@ -3,7 +3,6 @@
   <PropertyGroup>
     <AssemblyName>HotChocolate.Data.Sorting.Tests</AssemblyName>
     <RootNamespace>HotChocolate.Data</RootNamespace>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Data/test/Data.Tests/HotChocolate.Data.Tests.csproj b/src/HotChocolate/Data/test/Data.Tests/HotChocolate.Data.Tests.csproj
index 37c0ed1c1f9..4a31053692c 100644
--- a/src/HotChocolate/Data/test/Data.Tests/HotChocolate.Data.Tests.csproj
+++ b/src/HotChocolate/Data/test/Data.Tests/HotChocolate.Data.Tests.csproj
@@ -3,8 +3,6 @@
   <PropertyGroup>
     <RootNamespace>HotChocolate.Data</RootNamespace>
     <Nullable>enable</Nullable>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Data/test/Directory.Build.props b/src/HotChocolate/Data/test/Directory.Build.props
index bb1e03cc0ce..0cad47bb340 100644
--- a/src/HotChocolate/Data/test/Directory.Build.props
+++ b/src/HotChocolate/Data/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Diagnostics/test/Directory.Build.props b/src/HotChocolate/Diagnostics/test/Directory.Build.props
index 176c14c0a30..058ed278104 100644
--- a/src/HotChocolate/Diagnostics/test/Directory.Build.props
+++ b/src/HotChocolate/Diagnostics/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Fusion/src/Core/HotChocolate.Fusion.csproj b/src/HotChocolate/Fusion/src/Core/HotChocolate.Fusion.csproj
index 48c740c26f4..9079b0e5b24 100644
--- a/src/HotChocolate/Fusion/src/Core/HotChocolate.Fusion.csproj
+++ b/src/HotChocolate/Fusion/src/Core/HotChocolate.Fusion.csproj
@@ -7,9 +7,7 @@
     <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
     <!--EnableTrimAnalyzer>true</EnableTrimAnalyzer-->
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Fusion/src/Directory.Build.props b/src/HotChocolate/Fusion/src/Directory.Build.props
index 1940ce0c2c2..4f91211e2ae 100644
--- a/src/HotChocolate/Fusion/src/Directory.Build.props
+++ b/src/HotChocolate/Fusion/src/Directory.Build.props
@@ -5,8 +5,6 @@
   <PropertyGroup>
     <NoWarn>$(NoWarn);CA1812</NoWarn>
     <Nullable>enable</Nullable>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
 </Project>
diff --git a/src/HotChocolate/Fusion/test/Directory.Build.props b/src/HotChocolate/Fusion/test/Directory.Build.props
index 8db8a5f53ed..591f6a1a073 100644
--- a/src/HotChocolate/Fusion/test/Directory.Build.props
+++ b/src/HotChocolate/Fusion/test/Directory.Build.props
@@ -7,7 +7,6 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Language/test/Directory.Build.props b/src/HotChocolate/Language/test/Directory.Build.props
index ab79f1341ef..88b2985346c 100644
--- a/src/HotChocolate/Language/test/Directory.Build.props
+++ b/src/HotChocolate/Language/test/Directory.Build.props
@@ -5,7 +5,6 @@
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Marten/Directory.Build.props b/src/HotChocolate/Marten/Directory.Build.props
index f99d5c0038c..7c7c59d0f97 100644
--- a/src/HotChocolate/Marten/Directory.Build.props
+++ b/src/HotChocolate/Marten/Directory.Build.props
@@ -6,8 +6,6 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <NoWarn>$(NoWarn);CA1062</NoWarn>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NeutralLanguage>en</NeutralLanguage>
   </PropertyGroup>
 
diff --git a/src/HotChocolate/Marten/test/Directory.Build.props b/src/HotChocolate/Marten/test/Directory.Build.props
index b8eb56ec574..13473ca9c82 100644
--- a/src/HotChocolate/Marten/test/Directory.Build.props
+++ b/src/HotChocolate/Marten/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/MongoDb/Directory.Build.props b/src/HotChocolate/MongoDb/Directory.Build.props
index f99d5c0038c..7c7c59d0f97 100644
--- a/src/HotChocolate/MongoDb/Directory.Build.props
+++ b/src/HotChocolate/MongoDb/Directory.Build.props
@@ -6,8 +6,6 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <NoWarn>$(NoWarn);CA1062</NoWarn>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NeutralLanguage>en</NeutralLanguage>
   </PropertyGroup>
 
diff --git a/src/HotChocolate/MongoDb/test/Directory.Build.props b/src/HotChocolate/MongoDb/test/Directory.Build.props
index 0380cd7eb21..8f4e0c1f5d3 100644
--- a/src/HotChocolate/MongoDb/test/Directory.Build.props
+++ b/src/HotChocolate/MongoDb/test/Directory.Build.props
@@ -6,7 +6,6 @@
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/OpenApi/test/Directory.Build.props b/src/HotChocolate/OpenApi/test/Directory.Build.props
index fa9b7505f43..095f8716f9c 100644
--- a/src/HotChocolate/OpenApi/test/Directory.Build.props
+++ b/src/HotChocolate/OpenApi/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Pagination/Directory.Build.props b/src/HotChocolate/Pagination/Directory.Build.props
index 325cc8b5e02..2ea8ccc1689 100644
--- a/src/HotChocolate/Pagination/Directory.Build.props
+++ b/src/HotChocolate/Pagination/Directory.Build.props
@@ -4,9 +4,7 @@
   <PropertyGroup>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
     <NoWarn>$(NoWarn);CA1062</NoWarn>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
     <NeutralLanguage>en</NeutralLanguage>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
diff --git a/src/HotChocolate/Pagination/test/Directory.Build.props b/src/HotChocolate/Pagination/test/Directory.Build.props
index bb1e03cc0ce..0cad47bb340 100644
--- a/src/HotChocolate/Pagination/test/Directory.Build.props
+++ b/src/HotChocolate/Pagination/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/PersistedQueries/test/Directory.Build.props b/src/HotChocolate/PersistedQueries/test/Directory.Build.props
index 0172157324f..4d8fc779ae9 100644
--- a/src/HotChocolate/PersistedQueries/test/Directory.Build.props
+++ b/src/HotChocolate/PersistedQueries/test/Directory.Build.props
@@ -7,7 +7,6 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Primitives/src/Directory.Build.props b/src/HotChocolate/Primitives/src/Directory.Build.props
index 39d1ae0c655..e49b4859bbb 100644
--- a/src/HotChocolate/Primitives/src/Directory.Build.props
+++ b/src/HotChocolate/Primitives/src/Directory.Build.props
@@ -13,9 +13,6 @@
     <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</IsTrimmable>
     <EnableTrimAnalyzer Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</EnableTrimAnalyzer>
     <IsAotCompatible>true</IsAotCompatible>
-
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
 </Project>
diff --git a/src/HotChocolate/Primitives/test/Directory.Build.props b/src/HotChocolate/Primitives/test/Directory.Build.props
index fca9dc19569..2f395aa59c0 100644
--- a/src/HotChocolate/Primitives/test/Directory.Build.props
+++ b/src/HotChocolate/Primitives/test/Directory.Build.props
@@ -5,7 +5,6 @@
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Raven/Directory.Build.props b/src/HotChocolate/Raven/Directory.Build.props
index f99d5c0038c..7c7c59d0f97 100644
--- a/src/HotChocolate/Raven/Directory.Build.props
+++ b/src/HotChocolate/Raven/Directory.Build.props
@@ -6,8 +6,6 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <NoWarn>$(NoWarn);CA1062</NoWarn>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NeutralLanguage>en</NeutralLanguage>
   </PropertyGroup>
 
diff --git a/src/HotChocolate/Raven/test/Directory.Build.props b/src/HotChocolate/Raven/test/Directory.Build.props
index b8eb56ec574..13473ca9c82 100644
--- a/src/HotChocolate/Raven/test/Directory.Build.props
+++ b/src/HotChocolate/Raven/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Skimmed/test/Directory.Build.props b/src/HotChocolate/Skimmed/test/Directory.Build.props
index e9d9fa9c283..a9bcf7a6c5d 100644
--- a/src/HotChocolate/Skimmed/test/Directory.Build.props
+++ b/src/HotChocolate/Skimmed/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Spatial/Directory.Build.props b/src/HotChocolate/Spatial/Directory.Build.props
index 05e719235e0..923b4623c85 100644
--- a/src/HotChocolate/Spatial/Directory.Build.props
+++ b/src/HotChocolate/Spatial/Directory.Build.props
@@ -4,8 +4,6 @@
   <PropertyGroup>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
-    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NeutralLanguage>en</NeutralLanguage>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
diff --git a/src/HotChocolate/Spatial/test/Directory.Build.props b/src/HotChocolate/Spatial/test/Directory.Build.props
index b8eb56ec574..13473ca9c82 100644
--- a/src/HotChocolate/Spatial/test/Directory.Build.props
+++ b/src/HotChocolate/Spatial/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/HotChocolate/Utilities/test/Directory.Build.props b/src/HotChocolate/Utilities/test/Directory.Build.props
index 000269cf55e..1e372395c03 100644
--- a/src/HotChocolate/Utilities/test/Directory.Build.props
+++ b/src/HotChocolate/Utilities/test/Directory.Build.props
@@ -5,7 +5,6 @@
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/StrawberryShake/Client/test/Directory.Build.props b/src/StrawberryShake/Client/test/Directory.Build.props
index 3467ef489bb..736e4645c97 100644
--- a/src/StrawberryShake/Client/test/Directory.Build.props
+++ b/src/StrawberryShake/Client/test/Directory.Build.props
@@ -5,7 +5,6 @@
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/StrawberryShake/CodeGeneration/test/Directory.Build.props b/src/StrawberryShake/CodeGeneration/test/Directory.Build.props
index 65944b9c1de..a38813d8d7b 100644
--- a/src/StrawberryShake/CodeGeneration/test/Directory.Build.props
+++ b/src/StrawberryShake/CodeGeneration/test/Directory.Build.props
@@ -6,7 +6,6 @@
     <IsPackable>false</IsPackable>
     <ImplicitUsings>enable</ImplicitUsings>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/StrawberryShake/Tooling/test/Directory.Build.props b/src/StrawberryShake/Tooling/test/Directory.Build.props
index 17e6f32bde1..54da99de2f1 100644
--- a/src/StrawberryShake/Tooling/test/Directory.Build.props
+++ b/src/StrawberryShake/Tooling/test/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>