positive and negative relu activation function 'linear' operators #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 96.21% 96.23% +0.02%
==========================================
Files 35 37 +2
Lines 687 691 +4
==========================================
+ Hits 661 665 +4
Misses 26 26 ☔ View full report in Codecov by Sentry. |
samtkaplan
approved these changes
Jul 15, 2021
Member
samtkaplan
left a comment
samtkaplan
left a comment
There was a problem hiding this comment.
looks good. Ieft one code comment.
| @@ -0,0 +1,40 @@ | |||
| using LinearAlgebra, Jets, JetPack, Test | |||
|
|
|||
| # note no need for a linearity test as function is "linear" for x > 0 and constant for x <= 0 | |||
Member
There was a problem hiding this comment.
Is this comment in error. It seems to contradict the fact that there is a linearity test below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JopReluMinandJopReluMaxtests rely on change toJetsallowing specifying vectors tolinearity_test