Skip to content

tweak english, move tabs in Popup.jsx #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iamsirsammy
Copy link
Contributor

This has a few small tweaks to the english localization, mostly renaming Feature Pages to history, and same for Conversation Page/Window. The localization is pretty good now, but I have two questions:

  • Should I be editing the english language from src/_locales/en/main.json?
  • What does the option "Always Create New Conversation Window" do? Does it save every conversation or something else

Thanks

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the English localization by renaming "Feature Pages" to "History" and adjusts the tab ordering in Popup.jsx. Key changes include:

  • Repositioning the "Feature Pages" tab in Popup.jsx.
  • Updating localization keys in src/_locales/en/main.json (e.g., renaming "Feature Pages" to "History", and adjusting other related keys).
  • Minor text adjustments for clarity (e.g., capitalization, phrasing).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/popup/Popup.jsx Moved the "Feature Pages" tab to a new location in the tab list.
src/_locales/en/main.json Updated localization strings to reflect new naming conventions.
Comments suppressed due to low confidence (1)

src/popup/Popup.jsx:102

  • The translation key used here ('Feature Pages') now returns 'History' due to the update in main.json. Consider renaming the key in the call to t('History') for clarity and consistency.
<Tab className="popup-tab">{t('Feature Pages')}</Tab>

@PeterDaveHello
Copy link
Member

/review

Copy link

qodo-merge-pro bot commented Jun 2, 2025

Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Tab Order Change

The PR moves the "Feature Pages" tab to the end of the tab list, but also renames it to "History" in the localization file. The tab name should be updated to use the new localization.

  <Tab className="popup-tab">{t('Feature Pages')}</Tab>
</TabList>

@PeterDaveHello
Copy link
Member

/improve

Copy link

qodo-merge-pro bot commented Jun 2, 2025

Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants