Simplify get_verify

Author: jacomago

channelfinder/ChannelFinderClient.py

@@ -13,6 +13,7 @@
 from requests.adapters import HTTPAdapter
 from requests.exceptions import HTTPError
 from copy import copy
+from typing import Optional
 
 try:
     from json import JSONEncoder
@@ -53,21 +54,7 @@ def __init__(self, BaseURL=None, username=None, password=None, verify=None):
             self.__auth = None
         self.__session = requests.Session()
         self.__session.mount(self.__baseURL, HTTPAdapter())
-        if verify is not None:
-            self.__session.verify = verify
-        else:
-            verify_str = self.__getDefaultConfig("verify", None)
-            if verify_str is None:
-                self.__session.verify = True
-            elif verify_str.lower() in ("1", "true", "on", "yes"):
-                self.__session.verify = verify = True
-            elif verify_str.lower() in ("0", "false", "off", "no"):
-                self.__session.verify = verify = False
-            else:
-                # The verify option can also be a path to the trust store, so
-                # if it does not match any of the special strings, we assume
-                # that the string should be used as-is.
-                self.__session.verify = verify_str
+        self.__verify = self._get_boolean_config("verify", verify)
 
     def __getDefaultConfig(self, key, override):
         """
@@ -83,6 +70,20 @@ def __getDefaultConfig(self, key, override):
             result = basecfg["DEFAULT"].get(key, None)
         return result
 
+    def _get_boolean_config(self, key: str, override: Optional[bool]) -> bool:
+        """
+        Get boolean configuration for given name and section.
+
+        :param key: key word
+        :param override: override value
+        :return: ``override`` if not ``None``, else the configuration value
+            associated with ``key`` if present, otherwise ``None``.
+        """
+        result = override
+        if override is None:
+            result = basecfg["DEFAULT"].getboolean(key, None)
+        return bool(result)
+
     def set(self, **kwds):
         """
         method to allow various types of set operations on one or many channels, tags or properties