-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up prettier-ignore in tests #6464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6464 +/- ##
=========================================
Coverage 61.66% 61.66%
=========================================
Files 554 554
Lines 58078 58078
Branches 1837 1837
=========================================
Hits 35811 35811
Misses 22228 22228
Partials 39 39 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
requested changes
Feb 22, 2024
nazarhussain
previously approved these changes
Feb 22, 2024
wemeetagain
approved these changes
Feb 22, 2024
🎉 This PR is included in v1.17.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During initial vitest migration we have added timeout as part of options (2nd param) to tests. This would have caused an extra indentation which is why
prettier-ignore
was added in some cases to make review easier.But the better approach in almost all cases is to set timeout via
vi.setConfig({testTimeout: ...});
, as this does not cause formatting changes (extra indent) and it is more visible.Description
prettier-ignore
in testsvi.setConfig