Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ttl_seen valid lifetime of an attestation/aggregate to 2 epochs #6567

Closed
philknows opened this issue Mar 19, 2024 · 0 comments · Fixed by #6569
Closed

Extend ttl_seen valid lifetime of an attestation/aggregate to 2 epochs #6567

philknows opened this issue Mar 19, 2024 · 0 comments · Fixed by #6569
Labels
scope-networking All issues related to networking, gossip, and libp2p.

Comments

@philknows
Copy link
Member

Problem description

We've also confirmed that we are seeing spam post-Deneb under the aggregate channel.

photo_2024-03-19 09 53 37

Solution description

Then net effect of the above change is that peers are allowed to republish old aggregates and attestations and libp2p will not stop the spread with the settings we recommend - instead the messages will have to be stopped with the "attestation cover rule" or similar, even though they have been observed already.

Additional context

Reference: ethereum/consensus-specs#3627

@philknows philknows added the scope-networking All issues related to networking, gossip, and libp2p. label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant