Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for gossip messages #6554

Open
nazarhussain opened this issue Mar 16, 2024 · 0 comments
Open

Improve logging for gossip messages #6554

nazarhussain opened this issue Mar 16, 2024 · 0 comments
Labels
meta-feature-request Issues to track feature requests. scope-logging Issue about logs: hygiene, format issues, improvements.

Comments

@nazarhussain
Copy link
Contributor

Problem description

We recently encountered a scenario where we faced an error from the beacon API endpoint.

error: Failed to send out exit message "PublishError.InsufficientPeers"

During the debugging, we could not find any such error been logged anywhere. The validator-ejector called the beacon API, which internally called the libp2p-gosshipsub, and that error was raised there and then triggered back to API response, and not logged any where in our code.

Solution description

We should improve the logging for the gossip messages:

  1. Log all invocation any gossip message to any topic
  2. Log success or error for any publishing message to any topic

Additional context

Having those logs on the debug level would be sufficient.

@nazarhussain nazarhussain added the meta-feature-request Issues to track feature requests. label Mar 16, 2024
@philknows philknows added the scope-logging Issue about logs: hygiene, format issues, improvements. label Mar 16, 2024
@philknows philknows added this to the v1.18.0 milestone Mar 16, 2024
@philknows philknows modified the milestones: v1.18.0, v1.19.0 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests. scope-logging Issue about logs: hygiene, format issues, improvements.
Projects
None yet
Development

No branches or pull requests

2 participants