Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish all attestations on the Beacon API Event stream #5430

Closed
Savid opened this issue Apr 28, 2023 · 2 comments · Fixed by #5596
Closed

Publish all attestations on the Beacon API Event stream #5430

Savid opened this issue Apr 28, 2023 · 2 comments · Fixed by #5596
Labels
prio-high Resolve issues as soon as possible. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.

Comments

@Savid
Copy link
Contributor

Savid commented Apr 28, 2023

Is your feature request related to a problem? Please describe.

It looks like only aggregated attestations from block imports are published on the /eth/v1/events attestation topic.

Describe the solution you'd like

Publish all attestations received from currently subscribed subnets on the /eth/v1/events attestation topic.

Additional context

Currently we run multiple CL clients and collect attestation data. Would love to also include Lodestar as one of the sources! Apologies if I've missed a CLI flag somewhere and this is already implemented. I also understand there could potential performance issues in implementing this. Thanks

@dapplion
Copy link
Contributor

Hey @Savid happy to align Lodestar to other CL implementations. From your experience, do other clients emit attestation events for attestations received either via:

  • block import
  • gossip aggregated topic
  • gossip unaggregated topic
  • API post aggregated
  • API post unaggregated

@Savid
Copy link
Contributor Author

Savid commented May 1, 2023

Awesome @dapplion! I only have experience from gossip/block imports as I haven't tested API. All other CL implementations are at least publishing gossip/block import attestations.
Naively I would say all of the items you listed are applicable; The node has received a valid attestation (from P2P or API), but selfishly I only require gossip/block import.

@dapplion dapplion added scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. prio-high Resolve issues as soon as possible. labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants