Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Validator life cycle changes #5192

Open
maschad opened this issue Feb 22, 2023 · 2 comments
Open

Log Validator life cycle changes #5192

maschad opened this issue Feb 22, 2023 · 2 comments
Labels
meta-feature-request Issues to track feature requests. scope-logging Issue about logs: hygiene, format issues, improvements.

Comments

@maschad
Copy link
Contributor

maschad commented Feb 22, 2023

Is your feature request related to a problem? Please describe.

Following up from the discussion on improving validator status logging we would like to log the status of a validator lifecycle to give the user more incremental updates about the status of the validators.

Describe the solution you'd like

Ideally, we could log a Validator's voting status when it is discovered by the beacon chain along with some meta-data.

i.e. is a validator's lifecycle going through pending -> active -> exited -> withdrawn and then we can log the total validators.

Additional context

Upon initialization Lighthouse would log

Nov 23 08:24:23.745 INFO Initialized validators                  enabled: 2, disabled: 0
Nov 23 08:24:23.757 INFO Connected to beacon node                endpoint: http://localhost:5052/, version: Lighthouse/v3.2.1-6d5a2b5/x86_64-linux
Nov 23 08:24:23.758 INFO Initialized beacon node connections     available: 1, total: 1
Nov 23 08:24:23.758 INFO Loaded validator keypair store          voting_validators: 2
Nov 23 08:24:23.764 INFO Validator exists in beacon chain        fee_recipient: 0x0000…abcd, validator_index: 123456, pubkey: 0x00001, service: duties
Nov 23 08:24:23.764 INFO Validator exists in beacon chain        fee_recipient: 0x0000…abcd, validator_index: 123457, pubkey: 0x00001, service: duties

for instance. As mentioned here Certainly it owuld be useful to have the fee_receipient , signing_method and total_voting_validators included.

@dapplion
Copy link
Contributor

The text Validator exists in beacon chain sounds very reasonable and correct. Logging it only at initialization is fine

@philknows
Copy link
Member

As mentioned in #5507 (comment), there are still some outstanding questions relating to this log change:

  • Define how status changes should be handled
  • Define how newly discovered validators should be handled

@philknows philknows added scope-logging Issue about logs: hygiene, format issues, improvements. meta-feature-request Issues to track feature requests. labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests. scope-logging Issue about logs: hygiene, format issues, improvements.
Projects
None yet
Development

No branches or pull requests

3 participants