Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging for exit-validator if key is not yet activated on beacon chain #4540

Closed
philknows opened this issue Sep 12, 2022 · 3 comments · Fixed by #5756
Closed

Better logging for exit-validator if key is not yet activated on beacon chain #4540

philknows opened this issue Sep 12, 2022 · 3 comments · Fixed by #5756
Labels
prio-medium Resolve this some time soon (tm). scope-ux Issues for CLI UX or general consumer UX.

Comments

@philknows
Copy link
Member

Is your feature request related to a problem? Please describe.

As described by Somer, when trying to voluntary-exit a validator that is not yet activated on the beacon chain, Lodestar responds with an error such as:

ethstaker@ETH-STAKER-001:/usr/local/bin/lodestar$ ./lodestar validator voluntary-exit --network goerli --dataDir /var/lib/lodestar/validators --pubkeys 0x874aef47324f0d1af666c25607f01f2f02e1c5297be17ade9f35205d3ef8e5d511ae1054f8876a33af67e6c329e5d18e
 ✖ Error: beacon node did not return status for pubkey 0x874aef47324f0d1af666c25607f01f2f02e1c5297be17ade9f35205d3ef8e5d511ae1054f8876a33af67e6c329e5d18e
    at file:///usr/local/bin/lodestar/packages/cli/src/cmds/validator/voluntaryExit.ts:153:13
    at Array.map (<anonymous>)
    at resolveValidatorIndexes (file:///usr/local/bin/lodestar/packages/cli/src/cmds/validator/voluntaryExit.ts:150:24)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.handler (file:///usr/local/bin/lodestar/packages/cli/src/cmds/validator/voluntaryExit.ts:82:30)

Describe the solution you'd like

A better log response from Lodestar to the user. Something along the lines of: Validator is not yet active and cannot be exited is more understandable to a user.

@philknows philknows added prio-medium Resolve this some time soon (tm). scope-ux Issues for CLI UX or general consumer UX. labels Sep 12, 2022
@dapplion
Copy link
Contributor

Note that if the key has a typo it will also get the same respond, even if the key is already active. What's really happening is that the key is not known in current beacon chain state. But that's not that a helpful message

@philknows
Copy link
Member Author

Maybe something at least that encompasses the fact that the Validator pubkey is unknown: Re-check the pubkey submitted or wait until activated on the beacon chain to voluntary-exit

@nflaig
Copy link
Member

nflaig commented Jun 13, 2023

./lodestar validator voluntary-exit and it said:
100% of local key stores imported. current=0 total=0 rate=0.00keys/m Loaded keystores via keystore cache
“? Confirm to exit pub keys at epoch 207748 from network main net?”

The voluntary exit command might also be confusing ☝️ if there are no pub keys to exit because no keys are imported. Ideally,
we don't want to print out Confirm to exit pub keys at epoch 207748 from network main net at all if validatorsToExit=0.

const validatorsToExit = await resolveValidatorIndexes(client, signersToExit);

There must be a more explicit message that tells the user that there are 0 validators to exit which should be considered an error condition for this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-ux Issues for CLI UX or general consumer UX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants