Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize test utils #4031

Open
wemeetagain opened this issue May 18, 2022 · 0 comments
Open

Reorganize test utils #4031

wemeetagain opened this issue May 18, 2022 · 0 comments
Labels
prio-low This is nice to have. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@wemeetagain
Copy link
Member

wemeetagain commented May 18, 2022

Is your feature request related to a problem? Please describe.

Many tests in lodestar, fork choice, etc depend on test utilities defined in state-transition/test/util.
There may be other instances of test utilities being imported across packages.

Describe the solution you'd like

Export test utilities in a separate package. This could include many/any utilities that help generate states or other consensus objects.

Describe alternatives you've considered

Leave as is.

Additional context

See https://github.com/ChainSafe/lodestar/blob/master/packages/fork-choice/test/perf/protoArray/computeDeltas.test.ts#L9 as an example

@philknows philknows added meta-discussion Indicates a topic that requires input from various developers. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. labels May 19, 2022
@wemeetagain wemeetagain mentioned this issue Jul 14, 2022
20 tasks
@philknows philknows added prio-low This is nice to have. and removed meta-discussion Indicates a topic that requires input from various developers. labels Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-low This is nice to have. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Development

No branches or pull requests

2 participants