Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightclient may use a missed block as best partial update #3932

Closed
twoeths opened this issue Apr 18, 2022 · 2 comments · Fixed by #3967
Closed

Lightclient may use a missed block as best partial update #3932

twoeths opened this issue Apr 18, 2022 · 2 comments · Fixed by #3967
Assignees

Comments

@twoeths
Copy link
Contributor

twoeths commented Apr 18, 2022

Describe the bug

Lightclient uses a missed block as best partial update, for example

signedHeaderRoot: 0x43bed465664abeda7e58deeb1e2eff4234b837ed919245857e529330215d2277
signedHeaderSlot: 2775712

notice that the next slot (2775713) is missed so that should not be the best partial update

Expected behavior

It's likely that the block comes very late and it's not part of canonical chain (see #3925).

Should we only update best partial update only once the block is finalized? Or at least only update it only once the block becomes new head.

@twoeths twoeths changed the title Lightclient uses a missed block as best partial update Lightclient may use a missed block as best partial update Apr 18, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Apr 18, 2022

Update: the above log is not an evident for the issue as root 2775712 could be attested by the next 2 slot, 2775714

but it could be potentially an issue: an imported block may not be part of the canonical chain after all

@dapplion
Copy link
Contributor

That's a good point! The update could be computed only in response to a head change instead of importing a block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants