Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit code and our deps for Prototype pollution #3879

Open
2 tasks
dapplion opened this issue Apr 3, 2022 · 1 comment
Open
2 tasks

Audit code and our deps for Prototype pollution #3879

dapplion opened this issue Apr 3, 2022 · 1 comment
Labels
meta-investigate Issues found that require further investigation and may not have a specific resolution/fix prio-medium Resolve this some time soon (tm). scope-security Issues that fix security issues: DOS, key leak, CVEs.

Comments

@dapplion
Copy link
Contributor

dapplion commented Apr 3, 2022

For reference https://learn.snyk.io/lessons/prototype-pollution/javascript/

Prototype pollution is an injection attack that targets JavaScript runtimes. With prototype pollution, an attacker might control the default values of an object's properties. This allows the attacker to tamper with the logic of the application and can also lead to denial of service or, in extreme cases, remote code execution.

  • Review Lodestar for unsafe deep merges and parsing. First target is the REST API
  • Review dependent libraries, specially SSZ
@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Apr 3, 2022
@dapplion dapplion added the scope-security Issues that fix security issues: DOS, key leak, CVEs. label May 10, 2022
@philknows philknows added the meta-investigate Issues found that require further investigation and may not have a specific resolution/fix label Nov 5, 2023
@philknows
Copy link
Member

We should investigate this more. Fastify should be handling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-investigate Issues found that require further investigation and may not have a specific resolution/fix prio-medium Resolve this some time soon (tm). scope-security Issues that fix security issues: DOS, key leak, CVEs.
Projects
None yet
Development

No branches or pull requests

2 participants