-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple epoch transitions per epoch #3276
Comments
@tuyennhv The first chart screenshot can be very miss-leading, three dots don't mean 3 epoch transitions. You should look into the actual count of epoch transitions and look at the step delta. |
@dapplion do you think 2 epoch transitions per epoch is good enough? In my understanding, it should be 1 most of the time |
No, 2 is very bad! hahaha It would be very strange that there a re-org always at the epoch boundary, we must be doing something wrong |
I was able to catch the additional non-regular epoch transition from
when we validate a gossip AggregateAndProof that comes from probably an out-of-sync node.
then we use regen to roll to the current epoch (which requires an epoch transition) in order to:
in this exact example, we could achieve the same result by just using the state at block 1408386 (head of the producer node) since we know it's 1 epoch earlier and we have the |
Oh good find @tuyennhv ! I've been rethinking our regen strategy and have my rough thoughts here. Could you take a look at this proposal and check if it would solve the issue? https://github.com/ChainSafe/lodestar/blob/dapplion%2Fregen-blackbox/packages/lodestar/src/chain/regen/interface.ts |
confirm that we can just use the state at either the attTargetRoot or blockRoot:
|
@dapplion yeah using |
Describe the bug
Right now for each epoch, we have 3 or 4 or 5 epoch transitions
The checkpoint state cache shows that we have no more than 3 states per epoch
Expected behavior
At least when getting attester duties, we may not need to rotate to the current epoch (most of the time) thanks to the
nextEpochShuffling
cachelodestar/packages/lodestar/src/api/impl/validator/index.ts
Line 283 in 96ca4d3
The text was updated successfully, but these errors were encountered: