From 6d61c4c1d59ca3654af2360000928d88798088f0 Mon Sep 17 00:00:00 2001 From: harkamal Date: Fri, 26 May 2023 18:02:56 +0530 Subject: [PATCH] fix unit tests --- .../reqresp/beaconBlocksMaybeBlobsByRoot.ts | 2 +- .../beacon-node/test/unit/util/kzg.test.ts | 33 +++++++++++-------- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/packages/beacon-node/src/network/reqresp/beaconBlocksMaybeBlobsByRoot.ts b/packages/beacon-node/src/network/reqresp/beaconBlocksMaybeBlobsByRoot.ts index 6bb746c15b98..962ca7bb48dc 100644 --- a/packages/beacon-node/src/network/reqresp/beaconBlocksMaybeBlobsByRoot.ts +++ b/packages/beacon-node/src/network/reqresp/beaconBlocksMaybeBlobsByRoot.ts @@ -19,7 +19,7 @@ export async function beaconBlocksMaybeBlobsByRoot( for (const block of allBlocks) { const blockRoot = config.getForkTypes(block.message.slot).BeaconBlock.hashTreeRoot(block.message); - const blobKzgCommitmentsLen = (block.message.body as deneb.BeaconBlockBody).blobKzgCommitments.length ?? 0; + const blobKzgCommitmentsLen = (block.message.body as deneb.BeaconBlockBody).blobKzgCommitments?.length ?? 0; for (let index = 0; index < blobKzgCommitmentsLen; index++) { blobIdentifiers.push({blockRoot, index}); } diff --git a/packages/beacon-node/test/unit/util/kzg.test.ts b/packages/beacon-node/test/unit/util/kzg.test.ts index d2d65067b13b..efd05e2565b6 100644 --- a/packages/beacon-node/test/unit/util/kzg.test.ts +++ b/packages/beacon-node/test/unit/util/kzg.test.ts @@ -1,6 +1,8 @@ import {expect} from "chai"; import {bellatrix, deneb, ssz} from "@lodestar/types"; import {BLOB_TX_TYPE, BYTES_PER_FIELD_ELEMENT} from "@lodestar/params"; +import {config} from "@lodestar/config/default"; +import {createBeaconConfig} from "@lodestar/config"; import { kzgCommitmentToVersionedHash, OPAQUE_TX_BLOB_VERSIONED_HASHES_OFFSET, @@ -9,7 +11,8 @@ import { import {loadEthereumTrustedSetup, initCKZG, ckzg, FIELD_ELEMENTS_PER_BLOB_MAINNET} from "../../../src/util/kzg.js"; import {validateBlobSidecars, validateGossipBlobSidecar} from "../../../src/chain/validation/blobSidecar.js"; -import {getDevBeaconNode} from "../../utils/node/beacon.js"; +import {generateState} from "../../utils/state.js"; +import {MockBeaconChain} from "../../utils/mocks/chain/chain.js"; describe("C-KZG", async () => { const afterEachCallbacks: (() => Promise | void)[] = []; @@ -37,20 +40,24 @@ describe("C-KZG", async () => { }); it("BlobSidecars", async () => { - const bn = await getDevBeaconNode({ - params: { - // eslint-disable-next-line @typescript-eslint/naming-convention - ALTAIR_FORK_EPOCH: 0, - // eslint-disable-next-line @typescript-eslint/naming-convention - BELLATRIX_FORK_EPOCH: 0, - // eslint-disable-next-line @typescript-eslint/naming-convention - CAPELLA_FORK_EPOCH: 0, - // eslint-disable-next-line @typescript-eslint/naming-convention - DENEB_FORK_EPOCH: 0, + const block = ssz.phase0.SignedBeaconBlock.defaultValue(); + const state = generateState({ + finalizedCheckpoint: { + epoch: 0, + root: ssz.phase0.BeaconBlock.hashTreeRoot(block.message), }, }); - afterEachCallbacks.push(() => bn.close()); + const beaconConfig = createBeaconConfig(config, state.genesisValidatorsRoot); + const chain = new MockBeaconChain({ + genesisTime: 0, + chainId: 0, + networkId: BigInt(0), + state, + config: beaconConfig, + }); + + afterEachCallbacks.push(() => chain.close()); const slot = 0; const blobs = [generateRandomBlob(), generateRandomBlob()]; @@ -93,7 +100,7 @@ describe("C-KZG", async () => { ); signedBlobSidecars.forEach(async (signedBlobSidecar) => { - await validateGossipBlobSidecar(bn.config, bn.chain, signedBlobSidecar, signedBlobSidecar.message.index); + await validateGossipBlobSidecar(chain.config, chain, signedBlobSidecar, signedBlobSidecar.message.index); }); }); });