From 3fd6b2ff2d3fe21d7e3a02482fe539dfa951833f Mon Sep 17 00:00:00 2001 From: harkamal Date: Sun, 6 Aug 2023 18:02:44 +0530 Subject: [PATCH] add todo for pre-emptive block/blobs pull --- .../src/network/processor/gossipHandlers.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/beacon-node/src/network/processor/gossipHandlers.ts b/packages/beacon-node/src/network/processor/gossipHandlers.ts index f269f5fad13e..c0a91a0ae812 100644 --- a/packages/beacon-node/src/network/processor/gossipHandlers.ts +++ b/packages/beacon-node/src/network/processor/gossipHandlers.ts @@ -254,6 +254,12 @@ export function getGossipHandlers(modules: ValidatorFnsModules, options: GossipH ); if (blockInput !== null) { handleValidBeaconBlock(blockInput, peerIdStr, seenTimestampSec); + } else { + // TODO DENEB: + // + // If block + blobs not fully recieved in the slot within some deadline, we should trigger block/blob + // pull using req/resp by root pre-emptively even though it will be trigged on seeing any block/blob + // gossip on next slot via missing parent checks } }, @@ -265,6 +271,12 @@ export function getGossipHandlers(modules: ValidatorFnsModules, options: GossipH const blockInput = await validateBeaconBlob(signedBlob, serializedData, topic.index, peerIdStr, seenTimestampSec); if (blockInput !== null) { handleValidBeaconBlock(blockInput, peerIdStr, seenTimestampSec); + } else { + // TODO DENEB: + // + // If block + blobs not fully recieved in the slot within some deadline, we should trigger block/blob + // pull using req/resp by root pre-emptively even though it will be trigged on seeing any block/blob + // gossip on next slot via missing parent checks } },