Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forks in Blocks with Different GRANDPA Digests Result in a Consensus Split (GSR-02) #2400

Closed
danforbes opened this issue Mar 18, 2022 · 0 comments · Fixed by #2519
Closed

Forks in Blocks with Different GRANDPA Digests Result in a Consensus Split (GSR-02) #2400

danforbes opened this issue Mar 18, 2022 · 0 comments · Fixed by #2519
Assignees
@EclesioMeloJunior

Comments

@danforbes
Copy link
Contributor

There is only one Handler which processes all blocks, on any fork. The Handler has fields relating to GRANDPA changes which are not updated if we switch to another fork. As a result the Handler will have incorrect values from the GRANDPA changes when we switch forks.

GRANDPA changes should be maintained separately for each fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EclesioMeloJunior EclesioMeloJunior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(state/grandpa): track changes across forks ChainSafe/gossamer
2 participants
@danforbes @EclesioMeloJunior