Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeepSource issues detected for Release V0.6.0 #1729

Closed
4 of 6 tasks
edwardmack opened this issue Aug 13, 2021 · 1 comment · Fixed by #1731
Closed
4 of 6 tasks

Fix DeepSource issues detected for Release V0.6.0 #1729

edwardmack opened this issue Aug 13, 2021 · 1 comment · Fixed by #1731

Comments

@edwardmack
Copy link
Member

edwardmack commented Aug 13, 2021

Task summary

During merge of development into main for release v0.6.0, DeepSource analysis detected the following issues:

  • Unused code in dot/network/host.go starting at line 228
  • Return of nil value detected in lib/scale/encode.go at line 128
  • Shadow of builtin detected in dot/rpc/service.go at line 94
  • Function call made to an unsafe package in dot/network/notifications.go at line 32
  • Audit the random number generation source (rand) in:
    • lib/trie/test_utils.go line 42
    • dot/state/test_helpers.go line 64
    • dot/network/utils.go line 71
    • dot/network/connmgr.go line 166
  • Empty body in an if or else branch in dot/rpc/modules/grandpa.go line 80

Specification reference

Other information and links

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants