Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postUpdate spec #11741

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix postUpdate spec #11741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bd70c3
fix postUpdate test
anne-gropler Jan 5, 2024
91fb632
add name to contributors
anne-gropler Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,3 +374,4 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
- [孙永政](https://github.com/syzdev)
- [Subhajit Saha](https://github.com/subhajits)
- [Jared Webber](https://github.com/jaredwebber)
- [Anne Gropler](https://github.com/anne-gropler)
6 changes: 3 additions & 3 deletions packages/engine/Specs/Scene/SceneSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,7 @@ describe(
s.destroyForSpecs();
});

it("alwayas raises preUpdate event prior to updating", function () {
it("always raises preUpdate event prior to updating", function () {
const s = createScene();

const spyListener = jasmine.createSpy("listener");
Expand All @@ -1207,11 +1207,11 @@ describe(
s.destroyForSpecs();
});

it("always raises preUpdate event after updating", function () {
it("always raises postUpdate event after updating", function () {
const s = createScene();

const spyListener = jasmine.createSpy("listener");
s.preUpdate.addEventListener(spyListener);
s.postUpdate.addEventListener(spyListener);

s.render();

Expand Down