Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postUpdate spec #11741

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix postUpdate spec #11741

merged 2 commits into from
Jan 8, 2024

Conversation

anne-gropler
Copy link
Contributor

@anne-gropler anne-gropler commented Jan 5, 2024

Description

I noticed that there are 2 Scene specs that do the same, but have different descriptions. I guess this is just a copy paste error, that's why postUpdate was missing. I updated that test, and fixed a typo in the other test.

Issue number and link

Let me know if you need an issue for that, I didn't create one because it's neither a feature nor a bug, just fixing a test that I presume not to be doing what it should do.

Testing plan

I ran the tests using npm run test and it works.

Author checklist

  • I have submitted a Contributor License Agreement yes, see fix #3674 #3675 (comment)
  • I have added my name to CONTRIBUTORS.md
  • [ ] I have updated CHANGES.md with a short summary of my change no, because it did not change the Cesium API
  • I have added or updated unit tests to ensure consistent code coverage
  • [ ] I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@anne-gropler anne-gropler changed the title Post update spec fix Fix postUpdate spec Jan 5, 2024
@ggetz
Copy link
Contributor

ggetz commented Jan 8, 2024

Great, thanks for catching this @anne-gropler! The fix works perfectly.

@ggetz ggetz merged commit 92463d0 into CesiumGS:main Jan 8, 2024
@anne-gropler anne-gropler deleted the postUpdate-spec-fix branch January 8, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants