Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate how deployCesium works in gulpfile.cjs #8716

Open
OmarShehata opened this issue Apr 1, 2020 · 0 comments
Open

Consolidate how deployCesium works in gulpfile.cjs #8716

OmarShehata opened this issue Apr 1, 2020 · 0 comments
Labels

Comments

@OmarShehata
Copy link
Contributor

gulpfile.cjs in master will currently upload all files to a single upload location:

return listAll(s3, bucketName, prefix, existingBlobs)

gulpfile.cjs in the cesium.com branch however needs to upload different directories to different upload locations, because Sandcastle lives at sandcastle.cesium.com, whereas the docs live at https://cesium.com/docs/cesiumjs-ref-doc/:

function uploadFiles(prefix, filePrefix, files) {

This difference made it hard to resolve a merge conflict during release, see discussion in: #8715

We should consolidate how the gulpfile deploys Cesium to avoid conflicts like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant