Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SceneTransforms.wgs84To* functions in 1.121 #12059

Closed
ggetz opened this issue Jul 1, 2024 · 3 comments · Fixed by #12156
Closed

Remove SceneTransforms.wgs84To* functions in 1.121 #12059

ggetz opened this issue Jul 1, 2024 · 3 comments · Fixed by #12156
Labels
good first issue An opportunity for first time contributors JTC

Comments

@ggetz
Copy link
Contributor

ggetz commented Jul 1, 2024 •
edited
Loading

The following functions were deprecated in #12000, and should be entirely removed for the 1.121 release:

  • SceneTransforms.wgs84ToDrawingBufferCoordinates has been deprecated. It will be removed in 1.121. Use SceneTransforms.worldToDrawingBufferCoordinates instead.
  • SceneTransforms.wgs84ToWindowCoordinates has been deprecated. It will be removed in 1.21. Use SceneTransforms.worldToWindowCoordinates instead.
@ggetz ggetz added good first issue An opportunity for first time contributors JTC labels Aug 19, 2024
@jvrjsanchez
Copy link
Contributor

Hi gabby, can i take on this issue for a first time from jtc?

@ggetz
Copy link
Contributor Author

ggetz commented Aug 21, 2024

@jvrjsanchez Go for it!

@jvrjsanchez jvrjsanchez mentioned this issue Aug 27, 2024
Merged
6 tasks
@jvrjsanchez
Copy link
Contributor

This update ensures that our codebase aligns with the latest changes and improves future maintainability.

  • Updated method calls in the codebase from wgs84ToDrawingBufferCoordinates to worldToDrawingBufferCoordinates.
  • Updated method calls in the codebase from wgs84ToWindowCoordinates to worldToWindowCoordinates.
  • Ran tests using the original gulpfile.js to execute them.
  • Verified that all tests for SceneTransforms pass successfully in different viewing modes (3D, ColumbusView, 2D) and frustum configurations.
  • Ensured that test output is correctly reported and errors are handled gracefully.

@cugljd cugljd mentioned this issue Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors JTC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecation Updates for SceneTransforms Methods jvrjsanchez/cesium
2 participants
@ggetz @jvrjsanchez