Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing children in the options of creating Entity will override _children #11101

Closed
i-tengfei opened this issue Feb 22, 2023 · 1 comment · Fixed by #11125
Closed

Passing children in the options of creating Entity will override _children #11101

i-tengfei opened this issue Feb 22, 2023 · 1 comment · Fixed by #11125

Comments

@i-tengfei
Copy link
Contributor

new Entity({ children: 1 })

return createProperty(
name,
`_${name.toString()}`,
`_${name.toString()}Subscription`,
defaultValue(configurable, false),
defaultValue(createPropertyCallback, createConstantProperty)
);

@ggetz
Copy link
Contributor

ggetz commented Feb 27, 2023

Thanks @i-tengfei, I agree this behavior appears to be unintended. Would you have any bandwidth to open a Pull Request to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants